fix(ios): fix Fleet Engine location reporting on iOS #74
+247
−236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerttu
force-pushed
the
fix/ios-fleet-engine-location-reporting
branch
from
74f4658 to
3c8e10c
Compare
Fixes two critical iOS bugs preventing Fleet Engine location reporting: 1. Fixed module export names to match JavaScript expectations - Changed RCTDeliveryDriverModule -> DeliveryDriverModule - Changed RCTRideSharingModule -> RideSharingModule - JavaScript code expects NativeModules.DeliveryDriverModule, not RCTDeliveryDriverModule 2. Fixed event dispatcher initialization to enable event emission - Added startObserving() call after allocating DriverEventDispatcher - Without this, hasListeners remained false and all events were silently dropped - Affects didSucceedVehicleUpdate and didFailVehicleUpdate events These changes enable proper location reporting to Fleet Engine on iOS, achieving parity with the Android implementation. Fixes #70
jokerttu
force-pushed
the
fix/ios-fleet-engine-location-reporting
branch
from
3c8e10c to
894efcf
Compare
illuminati1911
approved these changes
Dec 19, 2025
Contributor
illuminati1911
left a comment
illuminati1911
left a comment
There was a problem hiding this comment.
LGTM but are those yarn.lock changes intentional?
Contributor
Author
It's fine to upgrade the dependencies to yarn.lock time to time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two critical iOS bugs preventing Fleet Engine location reporting:
Fixed module export names to match JavaScript expectations
Fixed event dispatcher initialization to enable event emission
Fixes #70