Feat: Make cli argument vars to be slice of string
#1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows passing multiple variables files as input to CLI. Order of files is important as overlapped non-empty keys in yaml or json files will be overwritten by subsequent file. This change is backwards compatible as CLI library makes the slice definition to be repetition of the --vars argument. Using goss with single file produces same outputs with this code change as it was before. Usage: ``` ./goss --vars file1.yaml --vars file2.yaml validate ``` Issue ref: goss-org#1023 Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>
|
Hello @aelsabbahy, any time expectation when you could look at this change? |
|
Ping for visibility. If there is low amount of maintainers, I can offer my help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows passing multiple variables files as input to CLI. Order of files is important as overlapped non-empty keys in yaml or json files will be overwritten by subsequent file.
This change is backwards compatible because CLI library implements slice definition as repetition of the
--varsargument. Using goss with single file produces the same outputs with the code change as it was before.Usage:
Checklist
make test-alldoesn't exist anymore. Probably should bemake test-int-all.make testpasses correctly.make test-all(UNIX) passes. CI will also test thisDescription of change
Closes #1023
📚 Documentation preview 📚: https://goss--1024.org.readthedocs.build/en/1024/