Skip to content

Fix: JsonObject fields should not use replace() method with tristate_optionals #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Fix: JsonObject fields should not use replace() method with tristate_optionals #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions codegen/gql_code_builder/lib/src/tristate_optionals.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,14 @@ String _generateFieldDeserializers(
getTypeDefinitionNode(schemaSource.document, originalSymbolName);

//TODO this feels flaky, find a better way
// Check if type is a built collection (has replace method)
// JsonObject from built_value doesn't have replace method
final isJsonObject = type.symbol == "JsonObject" &&
type.url == "package:built_value/json_object.dart";

final isBuilder = type.url != null &&
!isWrappedValue &&
!isJsonObject &&
(typeDefNode is! ScalarTypeDefinitionNode &&
typeDefNode is! EnumTypeDefinitionNode);

Expand Down