Skip to content

Conversation

@zerok
Copy link
Contributor

@zerok zerok commented Jun 12, 2023

If yarn is available in the target environment (i.e. the grafana/grafana GHA) then prettier will be executed.

Fixes #42

@zerok zerok requested a review from a team June 12, 2023 09:33
@zerok zerok enabled auto-merge (squash) June 12, 2023 09:33
@zerok zerok disabled auto-merge June 12, 2023 09:38
Copy link

@dsotirakis dsotirakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, not sure about this create-a-PR-from-a-gha-thing :/
What about adding a yarn prettier:write command in the GHA itself as a job and then git diff to check if there are differences and ask from the author to run it themselves and apply the changes?

@zerok
Copy link
Contributor Author

zerok commented Jun 12, 2023

Hmmm, not sure about this create-a-PR-from-a-gha-thing :/ What about adding a yarn prettier:write command in the GHA itself as a job and then git diff to check if there are differences and ask from the author to run it themselves and apply the changes?

That action always created a PR. I just changed the formatting a bit since some of the conditonals didn't make any sense anymore 🙂

You mean adding prettier to the workflow? That's, sadly, not possible since the PR is created inside this action to limit complexity for the workflow itself. That was also the case with the previous implementation but I had hoped to somehow avoid having to call out to prettier 🙁

At this point I'm mostly out of ideas 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update-changelog should follow prettier format

2 participants