Skip to content

Pass the FS to k6deps #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 139 commits into from
Closed

Pass the FS to k6deps #4841

wants to merge 139 commits into from
+55,422 −3,222

Conversation

pablochacin
Copy link
Contributor

What?

Creates a bridge between the internally used afero.Fs library and golang's standard fs.FS and use it in the k6deps library.

Why?

afero.FS will eventually be removed from k6. Therefore, we want to prevent creating more dependencies from this library

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Requires grafana/k6deps#113

inancgumus and others added 30 commits June 5, 2025 10:50
@inancgumus
Fix scenario shortcut multiple usage errors
9ac8ced 
Closes grafana/k6-cloud#1056
@inancgumus
Use consistent error messages
d3400a6
@inancgumus
Use CODECOV_TOKEN from Vault instead of Github
5e7c8dd
@inancgumus @codebien
Tidy up test.yml vault steps
d9170f6 
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@ankur22
Add a count method in the injected script
a36a31b 
This will be used to retrieve the count of all elements that match the
given selector.
@ankur22
Add count method on ElementHandle
a31cf63 
This performs the count call on the ElementHandle with the specified
selector to look for within the element's DOM. Count will currently be
called on the document itself (the whole DOM).
@ankur22
Add count on Frame
0eb10e5
@ankur22
Add count to the locator
261d39c
@ankur22
Add count to the locator mapping file
d161821
@ankur22
Add a test for locator.count
8ac0ee6
@ankur22
Add Count to TestMappings
2e73028
@ankur22
Fix user in dockerfile
bf6a2de 
This fix helps those who are working with the image in k8s. Before this
change the user had to work with runAsUser in the pod manifest file,
which could lead to issues if the correct user wasn't used (which is
only 12345). This will mitigate that risk since we default to working
with 12345 and not k6.
@ankur22 @nadiamoe
Update Dockerfile
5a19bb5 
Co-authored-by: Nadia Santalla <roberto@santalla.io>
@dependabot
build(deps): bump the googles group across 1 directory with 3 updates (…
563bc46 
…#4835)

Bumps the googles group with 1 update in the / directory: [google.golang.org/grpc](https://github.com/grpc/grpc-go).


Updates `google.golang.org/grpc` from 1.72.1 to 1.73.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.72.1...v1.73.0)

Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250218202821-56aae31c358a to 0.0.0-20250324211829-b45e905df463
- [Commits](https://github.com/googleapis/go-genproto/commits)

Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250218202821-56aae31c358a to 0.0.0-20250324211829-b45e905df463
- [Commits](https://github.com/googleapis/go-genproto/commits)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-version: 1.73.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: googles
- dependency-name: google.golang.org/genproto/googleapis/api
  dependency-version: 0.0.0-20250324211829-b45e905df463
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: googles
- dependency-name: google.golang.org/genproto/googleapis/rpc
  dependency-version: 0.0.0-20250324211829-b45e905df463
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: googles
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @inancgumus
build(deps): bump the otel group with 6 updates
249a4fe 
Bumps the otel group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) | `1.35.0` | `1.36.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://github.com/open-telemetry/opentelemetry-go) | `1.35.0` | `1.36.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) | `1.35.0` | `1.36.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://github.com/open-telemetry/opentelemetry-go) | `1.35.0` | `1.36.0` |
| [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) | `1.35.0` | `1.36.0` |
| [go.opentelemetry.io/otel/trace](https://github.com/open-telemetry/opentelemetry-go) | `1.35.0` | `1.36.0` |


Updates `go.opentelemetry.io/otel` from 1.35.0 to 1.36.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.35.0...v1.36.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace` from 1.35.0 to 1.36.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.35.0...v1.36.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` from 1.35.0 to 1.36.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.35.0...v1.36.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` from 1.35.0 to 1.36.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.35.0...v1.36.0)

Updates `go.opentelemetry.io/otel/sdk` from 1.35.0 to 1.36.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.35.0...v1.36.0)

Updates `go.opentelemetry.io/otel/trace` from 1.35.0 to 1.36.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.35.0...v1.36.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/trace
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump github.com/evanw/esbuild from 0.25.4 to 0.25.5 (#4821)
c8ec2c0 
Bumps [github.com/evanw/esbuild](https://github.com/evanw/esbuild) from 0.25.4 to 0.25.5.
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.25.4...v0.25.5)

---
updated-dependencies:
- dependency-name: github.com/evanw/esbuild
  dependency-version: 0.25.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @ankur22
build(deps): bump the golangx group with 5 updates
1fb95fc 
Bumps the golangx group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [golang.org/x/crypto](https://github.com/golang/crypto) | `0.38.0` | `0.39.0` |
| [golang.org/x/net](https://github.com/golang/net) | `0.40.0` | `0.41.0` |
| [golang.org/x/sync](https://github.com/golang/sync) | `0.14.0` | `0.15.0` |
| [golang.org/x/time](https://github.com/golang/time) | `0.11.0` | `0.12.0` |
| [golang.org/x/text](https://github.com/golang/text) | `0.25.0` | `0.26.0` |


Updates `golang.org/x/crypto` from 0.38.0 to 0.39.0
- [Commits](golang/crypto@v0.38.0...v0.39.0)

Updates `golang.org/x/net` from 0.40.0 to 0.41.0
- [Commits](golang/net@v0.40.0...v0.41.0)

Updates `golang.org/x/sync` from 0.14.0 to 0.15.0
- [Commits](golang/sync@v0.14.0...v0.15.0)

Updates `golang.org/x/time` from 0.11.0 to 0.12.0
- [Commits](golang/time@v0.11.0...v0.12.0)

Updates `golang.org/x/text` from 0.25.0 to 0.26.0
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golangx
- dependency-name: golang.org/x/net
  dependency-version: 0.41.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golangx
- dependency-name: golang.org/x/sync
  dependency-version: 0.15.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golangx
- dependency-name: golang.org/x/time
  dependency-version: 0.12.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golangx
- dependency-name: golang.org/x/text
  dependency-version: 0.26.0
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: golangx
...

Signed-off-by: dependabot[bot] <support@github.com>
@inancgumus
Prevent testcov running for forks
79b04f5 
We can't retrieve secrets for public forks. Otherwise:

Run grafana/shared-workflows/actions/get-vault-secrets@get-vault-secrets/v1.2.1
Run ${GITHUB_ACTION_PATH}/translate-secrets.bash
Secrets that will be queried from Vault:
ci/data/repo/grafana/k6/CODECOV_TOKEN CODECOV_TOKEN | CODECOV_TOKEN;

Run actions/github-script@60a0d83
Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable
    at OidcClient.<anonymous> (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:585:23)
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:522:71
    at new Promise (<anonymous>)
    at __webpack_modules__.8041.__awaiter (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:518:12)
    at OidcClient.getIDToken (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:571:16)
    at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:421:46)
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:133:71
    at new Promise (<anonymous>)
Error: Unhandled error: Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable
@inancgumus
Skip running codecov upload on public forks
ee27d09
@ankur22
Fix nth parse in injected script
ab73b18 
The body is a number, and we treat it as a number in the injected
script. However it is set as a string due to how the selectors parsing
is done in the browser codebase.
@ankur22
Add detection of nth selector type
11dd1e2 
This allows the interpretation of the nth selector in the injected
script.
@ankur22
Add Nth in locator
b55dcd6
@ankur22
Add the mapping of the nth method for locator
e889229
@ankur22
Add test for locator.nth
2ba4839
@ankur22
Add locator.first
2794351 
This is a convenience method that is a wrapper around locator.nth(0).
@ankur22
Add locator.last
d522ae5 
This is a convenience method wrapping around locator.nth(-1), which
returns the last element that matches the selector.
@ankur22
Ignore lint issue
8342507 
This parse method will grow while we add more selectors. Refactoring
should be done after.
@ankur22 @inancgumus
Use string concat instead of sprintf
bf431a3 
It's more performant

Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
@ankur22
Fix fill method in injection script
c12984d 
This fill function was failing to fill the input text field. It would
seem that it was returning to early, when it should have continued onto
the end of the function and returned "needsinput".
@ankur22
Add a test for the Fill fix
418c9e2 
It relies on a react based website.
ankur22 and others added 12 commits July 18, 2025 11:40
@ankur22
Add error propagation if matcher fails with error
a3221c7
@ankur22
Add test for regex failure case
a101a27
@ankur22
Add a condition to prevent test from running on..
105277b 
... Windows for now.
@joanlopez
k6packager: Adjust versions of dependencies (s3cmd, aws) (#4879)
9cf2033 
* k6packager: Update s3cmd and aws

* Hard-code k6packager dependencies version

* Setup dependabot for k6packager dependencies

* Update the repository URLs to point to the Debian Archive
@dependabot @codebien
build(deps): bump debian in /packaging
31a6f8e 
Bumps debian from buster-20210311 to buster-20240612.

---
updated-dependencies:
- dependency-name: debian
  dependency-version: buster-20240612
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@mstoykov
chore: move to enumer versions that are working
7a5b33e 
The previous enumer implementation doesn't work with go > 1.20 which
practically makes it unusable. It has also have not been updated in
years.

There is a fork that unfortunately adds some additional functionality so
I decided to fork and bump versions.

But we already use this in a couple of places.

At this point I will make certain that the current code works as before
and we can agree on whether we use my minimal fork or the other one with
the additional (forced) functionality.
@mstoykov
k6/html: move wrongly moved gen/gen_elements.go back out of internal
9bb8f77
@mstoykov
cloudapi: fix proto definitions after move to internal
d64b142
@mstoykov
output/json: regenerate easyjson after move to internal
9ea333c
@codebien
Add Dependabot rule for the main Dockerfile
e8f572e
@codebien
Use alpine 3.22 for the builder
b5fb22b
@mstoykov
ci/deps: fail on go generate failing + refactor
dea6d51 
Move the whole generation part in the Makefile and pin everything used
in it. Including protoc, which will only work on linux or WSL, maybe.

This has to do some ... updates to some of the protobuf generated files
as they are now build with a specific version.

All versions are the highest one used so far, but no more recent to
decrease need to change stuff.
@codebien codebien requested review from mstoykov and codebien July 21, 2025 12:39
@pablochacin pablochacin force-pushed the bridge-aferofs branch 2 times, most recently from d5c3127 to e4a918f Compare July 21, 2025 15:42
pablochacin and others added 11 commits July 21, 2025 18:50
@pablochacin
initial integration
d4d0c2a 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
refactor provisioning into an interface
4cc25dc 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
use loadsurce to read source file
9846eaf 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
handle stdin
34c9fcb 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
attend review comments
96bfa9a 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
fix comment
a8582f0 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
add fsext bridge
4918704 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
pass bridge to ksdeps
4234f7e 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin @codebien
address review comments
70282cf 
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@pablochacin
move fs bridge to launcher
0e1b95d 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
add missing import
6360295 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
Copy link
Contributor Author

Closed in favor of #4958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 left review comments

@AgnesToulet AgnesToulet Awaiting requested review from AgnesToulet AgnesToulet is a code owner automatically assigned from grafana/k6-core

@mstoykov mstoykov Awaiting requested review from mstoykov

@codebien codebien Awaiting requested review from codebien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.