Skip to content

Ci stability #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2025
Merged

Ci stability #4914

merged 4 commits into from
Jul 23, 2025

Conversation

mstoykov
Copy link
Contributor

What?

Couple of fixes for tests that are flaky in the GHA CI

Why?

CI stability helps with development.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v1.2.0 milestone Jul 10, 2025
@mstoykov mstoykov requested a review from a team as a code owner July 10, 2025 12:57
@mstoykov mstoykov requested review from ankur22 and AgnesToulet and removed request for a team July 10, 2025 12:57
ankur22
ankur22 previously approved these changes Jul 10, 2025
View reviewed changes
@mstoykov mstoykov requested a review from ankur22 July 15, 2025 08:02
@mstoykov mstoykov mentioned this pull request Jul 22, 2025
Closed
8 tasks
codebien
codebien approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not particularly excited about reducing the concurrency on testing as it might push issues under the rug. However, it seems this is the trade-off we have to live with for now.

@mstoykov mstoykov merged commit 7c8eb46 into master Jul 23, 2025
68 of 75 checks passed
@mstoykov mstoykov deleted the ciStability branch July 23, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@codebien codebien codebien approved these changes

@AgnesToulet AgnesToulet Awaiting requested review from AgnesToulet AgnesToulet is a code owner automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @ankur22 @codebien