Skip to content

Small improvements for loki and node-exporter graph #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

Small improvements for loki and node-exporter graph #1743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8045fcc
add standard kubernetes labels
upodroid Jul 8, 2025
cf56c4f
add one metric used for node exporter dashboards
upodroid Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...itoring/charts/feature-cluster-metrics/default-allow-lists/node-exporter-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@
- node_systemd_service_restart_total
- node_systemd_unit_state
- node_textfile_scrape_error
- node_time_seconds
Copy link
Author

@upodroid upodroid Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/prometheus-operator/kube-prometheus/blob/main/manifests/grafana-dashboardDefinitions.yaml#L17384

- node_time_zone_offset_seconds
- node_timex_estimated_error_seconds
- node_timex_maxerror_seconds
Expand Down
5 changes: 5 additions & 0 deletions charts/k8s-monitoring/charts/feature-pod-logs/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ extraLogProcessingStages: ""
# @section -- Log Processing
labelsToKeep:
- app.kubernetes.io/name
- app.kubernetes.io/instance
Copy link
Author

@upodroid upodroid Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

- app.kubernetes.io/version
- app.kubernetes.io/component
- app.kubernetes.io/part-of
- app.kubernetes.io/managed-by
- container
- instance
- job
Expand Down
Loading