Skip to content

Conversation

@Segflow
Copy link
Contributor

@Segflow Segflow commented Dec 5, 2025

What this PR does / why we need it:

This PR is part of proposal 4 described in this design document.

PR grafana/dskit#799 adds the ability to lock state change, this PR updates the prepare downscale handler to return 409 if the state change is locked.

We also have a PR in rollout-operator that properly handles this status code: grafana/rollout-operator#343

Which issue(s) this PR fixes:
Fixes

Special notes for your reviewer:

This PR is marked as draft because we need grafana/dskit#799 to be merged first and update go.mod to latest dskit.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Segflow Segflow requested a review from a team as a code owner December 5, 2025 19:28
@Segflow Segflow marked this pull request as draft December 5, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant