Skip to content

Allow setting cookies from other origins #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow setting cookies from other origins #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion @app/server/src/middleware/installSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,15 @@ export default (app: Express) => {
* different authentication method such as bearer tokens.
*/
const wrappedSessionMiddleware: RequestHandler = (req, res, next) => {
if (req.isSameOrigin) {
const origins = [];
if (process.env.SESSION_ALLOWED_ORIGINS) {
origins.push(
...(process.env.SESSION_ALLOWED_ORIGINS?.replace(/s\s/g, "").split(
","
) || [])
);
}
if (req.isSameOrigin || origins.includes(req.get("Origin") || "")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename isSameOrigin to isAllowedOrigin and move this logic there.

Also, please process environmental variables in the root scope, near the top of the file, rather than within the middleware itself. At the moment this replace/split has to be executed for every single request which is an unnecessary cost.

sessionMiddleware(req, res, next);
} else {
next();
Expand Down