Remove GraphiQL Explorer; fix headers property #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
Nov 28, 2024
| onEditVariables: onEditVariables, | ||
| onEditOperationName: onEditOperationName, | ||
| headerEditorEnabled: @Model.HeaderEditorEnabled, | ||
| isHeadersEditorEnabled: @Model.HeaderEditorEnabled, |
There was a problem hiding this comment.
The HeaderEditorEnabled property was ineffective because the react property name was incorrect. This change fixes the bug.
Shane32
commented
Nov 28, 2024
| /// This property has no effect. | ||
| /// </summary> | ||
| [Obsolete("This property has no effect and will be removed in a future version.")] | ||
| public bool ExplorerExtensionEnabled { get; set; } = true; |
There was a problem hiding this comment.
There was no code tied to this property within the entire codebase. So it could not be disabled.
Shane32
commented
Nov 28, 2024
Comment on lines
-59
to
-69
| <script | ||
| src="https://unpkg.com/graphiql-with-extensions@0.14.3/graphiqlWithExtensions.min.js" | ||
| integrity="sha384-TqI6gT2PjmSrnEOTvGHLad1U4Vm5VoyzMmcKK0C/PLCWTnwPyXhCJY6NYhC/tp19" | ||
| crossorigin="anonymous" | ||
| ></script> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://unpkg.com/graphiql-with-extensions@0.14.3/graphiqlWithExtensions.css" | ||
| integrity="sha384-GBqwox+q8UtVEyBLBKloN5QDlBDsQnuoSUfMeJH1ZtDiCrrk103D7Bg/WjIvl4ya" | ||
| crossorigin="anonymous" | ||
| /> |
There was a problem hiding this comment.
graphiql-with-extensions was last released 5 years ago, and its package.json indicates that it was designed for version 0.14.2 of GraphiQL. It does not appear to be compatible with GraphiQL 3.x and so I removed it. GraphiQL does have a docs explorer built-in, although it does not have the checkbox functionality that the graphiql-explorer extension did.
See:
gao-artur
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ExplorerExtensionEnabled(which did nothing) as obsoleteHeaderEditorEnabledso it works properly