This repository was archived by the owner on Sep 22, 2020. It is now read-only.
WIP: Parse Stone through Acorn #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aracters after directives
…uring code generation
… type) that now handles for loops
* All view tests should now pass except for tags, as tagged components have not yet been implemented * The only test case that was updated is `nested` because pre-acorn stone was incorrectly trimming the last line of a template if it came after a directive * Moved `set-destructuring` to `set-destructuring-array` and added `set-destructuring-object`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stone currently uses a mix of regex and character scanning to parse it’s code, and awkwardly uses Acorn in places to scope vars and validate syntax.
This PR aims to replace the existing Stone compiler with a new parser built entirely on Acorn. The new
Stoneclass will parse templates via Acorn into and AST and then use astring to generate them into JS.Goals
Progress
Overall
Directives
@for/@endforand@foreach/@endforeach@while/@endwhile@continue/@continue(condition)@break/@break(condition)@if/@endif@elseif@else@unless/@endunless@include@each@extends@section/@endsection@yield@show@super/@parent@hassection@component/@endcomponent@slot/@endslot@spaceless/@endspaceless@dump@{{ raw output }}@set@unset@macro/@endmacro