xds: Introduce flag for fallback to use the xds channel authority if no SNI is determined to be used. #12422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I is determined to be used.
kannanjgithub
commented
Oct 16, 2025
| @Nullable protected final CertificateValidationContext staticCertificateValidationContext; | ||
| @Nullable protected AbstractMap.SimpleImmutableEntry<SslContext, X509TrustManager> | ||
| sslContextAndTrustManager; | ||
| protected boolean autoSniSanValidationDoesNotApply; |
There was a problem hiding this comment.
I made this a settable field that is set separately instead of making it a final field in CertProviderClientSslContextProvider where it ideally belongs, in order to avoid having to propagate the boolean via the cert provider factory methods and having to add the boolean to the cache key as well.
kannanjgithub
force-pushed
the
xdsAuthorityFallbackFlag
branch
from
bc2699a to
79ebe40
Compare
ejona86
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow the previous behavior if needed, and when the xds channel authority is used as the SNI, it won't be used for the SAN validation.