-
Notifications
You must be signed in to change notification settings - Fork 44
Fixed yuiseki's svg renderer #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DerAndereJohannes
wants to merge
8
commits into
gunyarakun:master
Choose a base branch
from
DerAndereJohannes:add-svg-renderer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a3ed5b2
add SVG.py
yuiseki 9d416eb
fixed: svg generation
DerAndereJohannes 8573c56
added: basic unit test file for svg
DerAndereJohannes 1b0f072
added: header information to svg_test file
DerAndereJohannes 58e36f9
fixed: issue when player had more than 9 of a piece in hand
DerAndereJohannes d8ae9bc
added: svg image to readme and how to save it as a file
DerAndereJohannes 3be5e32
fix: centered svg image in README
DerAndereJohannes 52afb4d
added: another unittest to test for double digits of pieces in hand
DerAndereJohannes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could embed a real image generated by the command
board.svg().But I know it's not easy.