Merge rocksample improvements from #84 and enable --benchmark flag #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkytony
force-pushed
the
kaiyu/merge_HarryXuancy
branch
from
9733de3 to
c284e34
Compare
HarryXuancy
approved these changes
Oct 26, 2025
Contributor
HarryXuancy
left a comment
HarryXuancy
left a comment
There was a problem hiding this comment.
Thank you for doing this! And I am sorry for my big delay. I was just going to update the changes this weekend and find you have already done them.
HarryXuancy
reviewed
Oct 26, 2025
Collaborator
Author
|
Thanks for the review! @HarryXuancy |
zkytony
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to merge #84
Credit: work by @HarryXuancy; Refer to this issue for more context:
Additionally, enables
--benchmarkflag like sowithout this flag, the command
python -m pomdp_py -r rocksamplewill run a quick example.