Fix toolbar flashing during navigation back with keyboard showing #2135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolbar was flashing when navigating back from a navigation controller while the keyboard remained visible. This occurred because
reloadInputViews()
(Swift) andaddToolbarIfRequired
(Objective-C) were being called unnecessarily during navigation transitions, causing the toolbar to be recreated and creating a visual flash.Root Cause
The issue was in the scroll animation completion blocks in both implementations:
Swift version:
Objective-C version:
Solution
Added checks to detect when interactive navigation gestures are active and skip toolbar recreation during those periods:
activeConfiguration.rootControllerConfiguration.isInteractiveGestureActive
interactivePopGestureRecognizer.state
for.began
and.changed
statesTesting
To reproduce and verify the fix:
navigationController.pushViewController
Impact
Fixes #2102.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.