Skip to content

Conversation

JamieXiao
Copy link
Contributor

Tickets:

  • HCK-

List of changes:

  • (I don't remember if the review statuses were previously merged or not)
  • Added functionality to reviewer comments
  • Added a new column in the 'Search Hackers' table called "Review Status" which shows the number of people that have reviewed a certain hacker's application
  • Added a filter for 'Review Status' (0,1,2)

Type of change:

Please delete options that aren't relevant.

  • New feature (non-breaking change which adds functionality)

How did you do this?

How to test:

Click on a hacker's "See more" and enter a reviewer status and name/comments. Wait a second or two, then click on the reload button. The changes should now be saved, and the hackers' "See more" should be updated as well as the "Review Status" column in the table (Note: the "Review Status" column only checks if the actual Reviewer Status is changed (AKA not none) or not; the name and comments do not matter).
Filter the table for hackers with 0/1/2 "Review Status".

Questions:

PR Checklist:

  • Merged develop branch (before testing)
  • Linted my code locally
  • Listed change(s) in the Changelog
  • Tested all links in project relevant browsers
  • Tested all links on different screen sizes
  • Referenced all useful info (issues, tasks, etc)

Screenshots:

image image

MikaVohl and others added 15 commits October 30, 2024 19:05
…dded phone number field to account creation. (#1005)

Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation.

* Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111

---------

Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
* Updated level of study options to match MLH requirements

* #1000 - Update export from .tsv to .csv

* Changed hacker account form 'birthdate' field to 'age' #1003

* Added country of residence field to Other/Personal Details section of hacker application #1009

* Added country of residence field to the hacker application.

* add back CEGEP level of study.

---------

Co-authored-by: allennatang <allennatang@gmail.com>
* Add 3rd checkbox to Terms and Conditions #1010

* MLH Form Changes (#1016)

* Updated level of study options to match MLH requirements

* #1000 - Update export from .tsv to .csv

* Changed hacker account form 'birthdate' field to 'age' #1003

* Added country of residence field to Other/Personal Details section of hacker application #1009

* Added country of residence field to the hacker application.

* add back CEGEP level of study.

---------

Co-authored-by: allennatang <allennatang@gmail.com>

* Added Jamie's changes for MLH checkbox, fixed merge conflicts.

* fixed dumb rebase error

---------

Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: allennatang <allennatang@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
…#1008)

* change-mchacks12

* change-mchacks12

* Remove Netlify link from README

* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005)

Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>

* Fix/fixed phone number input (#1006)

* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation.

* Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111

---------

Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>

* add success message and reset fields after an invite is successfully sent

* MLH Form Changes (#1016)

* Updated level of study options to match MLH requirements

* #1000 - Update export from .tsv to .csv

* Changed hacker account form 'birthdate' field to 'age' #1003

* Added country of residence field to Other/Personal Details section of hacker application #1009

* Added country of residence field to the hacker application.

* add back CEGEP level of study.

---------

Co-authored-by: allennatang <allennatang@gmail.com>

* Add 3rd checkbox to Terms and Conditions (#1012)

* Add 3rd checkbox to Terms and Conditions #1010

* MLH Form Changes (#1016)

* Updated level of study options to match MLH requirements

* #1000 - Update export from .tsv to .csv

* Changed hacker account form 'birthdate' field to 'age' #1003

* Added country of residence field to Other/Personal Details section of hacker application #1009

* Added country of residence field to the hacker application.

* add back CEGEP level of study.

---------

Co-authored-by: allennatang <allennatang@gmail.com>

* Added Jamie's changes for MLH checkbox, fixed merge conflicts.

* fixed dumb rebase error

---------

Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: allennatang <allennatang@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>

* change-mchacks12

---------

Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com>
Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com>
Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: allennatang <allennatang@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
* Add 3rd checkbox to Terms and Conditions #1010

* Update Grad Years in Filter

* MLH Form Changes (#1016)

* Updated level of study options to match MLH requirements

* #1000 - Update export from .tsv to .csv

* Changed hacker account form 'birthdate' field to 'age' #1003

* Added country of residence field to Other/Personal Details section of hacker application #1009

* Added country of residence field to the hacker application.

* add back CEGEP level of study.

---------

Co-authored-by: allennatang <allennatang@gmail.com>

* Clear the fields and add success message after sending account invite (#1008)

* change-mchacks12

* change-mchacks12

* Remove Netlify link from README

* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005)

Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>

* Fix/fixed phone number input (#1006)

* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation.

* Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111

---------

Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>

* add success message and reset fields after an invite is successfully sent

* MLH Form Changes (#1016)

* Updated level of study options to match MLH requirements

* #1000 - Update export from .tsv to .csv

* Changed hacker account form 'birthdate' field to 'age' #1003

* Added country of residence field to Other/Personal Details section of hacker application #1009

* Added country of residence field to the hacker application.

* add back CEGEP level of study.

---------

Co-authored-by: allennatang <allennatang@gmail.com>

* Add 3rd checkbox to Terms and Conditions (#1012)

* Add 3rd checkbox to Terms and Conditions #1010

* MLH Form Changes (#1016)

* Updated level of study options to match MLH requirements

* #1000 - Update export from .tsv to .csv

* Changed hacker account form 'birthdate' field to 'age' #1003

* Added country of residence field to Other/Personal Details section of hacker application #1009

* Added country of residence field to the hacker application.

* add back CEGEP level of study.

---------

Co-authored-by: allennatang <allennatang@gmail.com>

* Added Jamie's changes for MLH checkbox, fixed merge conflicts.

* fixed dumb rebase error

---------

Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: allennatang <allennatang@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>

* change-mchacks12

---------

Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com>
Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com>
Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: allennatang <allennatang@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>

---------

Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: allennatang <allennatang@gmail.com>
Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com>
Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com>
Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboard Ready Ready Preview Comment Sep 30, 2025 1:22am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants