-
Notifications
You must be signed in to change notification settings - Fork 9
Feat/create application review #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JamieXiao
wants to merge
15
commits into
develop
Choose a base branch
from
feat/create_application_review
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
* Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com>
* Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
…#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
* Add 3rd checkbox to Terms and Conditions #1010 * Update Grad Years in Filter * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
List of changes:
Type of change:
Please delete options that aren't relevant.
How did you do this?
How to test:
Click on a hacker's "See more" and enter a reviewer status and name/comments. Wait a second or two, then click on the reload button. The changes should now be saved, and the hackers' "See more" should be updated as well as the "Review Status" column in the table (Note: the "Review Status" column only checks if the actual Reviewer Status is changed (AKA not none) or not; the name and comments do not matter).
Filter the table for hackers with 0/1/2 "Review Status".
Questions:
PR Checklist:
develop
branch (before testing)Screenshots: