Skip to content

Add payment_bic and payment_payee_account_name to invoice #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
halfbyte merged 1 commit into from
Aug 28, 2025
Merged

Add payment_bic and payment_payee_account_name to invoice #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/secretariat/invoice.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ module Secretariat
:payment_terms_text,
:payment_due_date,
:payment_iban,
:payment_bic,
:payment_payee_account_name,
:tax_category,
:tax_percent,
:tax_amount,
Expand Down Expand Up @@ -263,9 +265,15 @@ def to_xml(version: 1, validate: true)
xml['ram'].SpecifiedTradeSettlementPaymentMeans do
xml['ram'].TypeCode payment_code
xml['ram'].Information payment_text
if payment_iban
if payment_iban || payment_payee_account_name
xml['ram'].PayeePartyCreditorFinancialAccount do
xml['ram'].IBANID payment_iban
xml['ram'].IBANID payment_iban if payment_iban
xml['ram'].AccountName payment_payee_account_name if payment_payee_account_name
end
end
if payment_bic
xml['ram'].PayeeSpecifiedCreditorFinancialInstitution do
xml['ram'].BICID payment_bic
end
end
end
Expand Down
2 changes: 2 additions & 0 deletions test/invoice_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,8 @@ def make_negative_de_invoice
payment_reference: 'INV 123123123',
payment_iban: 'DE02120300000000202051',
payment_terms_text: "Wir zahlen die Gutschrift unmittelbar aus",
payment_bic: 'BYLADEM1001',
payment_payee_account_name: 'Depfu inc',
tax_category: :STANDARDRATE,
tax_amount: BigDecimal('-38'),
basis_amount: BigDecimal('-200'),
Expand Down