Skip to content

add field buyer#person_name (BT-56) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
halfbyte merged 1 commit into from
Dec 3, 2025
Merged

add field buyer#person_name (BT-56) #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/secretariat/trade_party.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module Secretariat

TradeParty = Struct.new('TradeParty',
:name, :street1, :street2, :city, :postal_code, :country_id, :vat_id, :global_id, :global_id_scheme_id, :tax_id,
:person_name,
keyword_init: true,
) do
def to_xml(xml, exclude_tax: false, version: 2)
Expand All @@ -28,6 +29,11 @@ def to_xml(xml, exclude_tax: false, version: 2)
end
end
xml['ram'].Name name
if person_name
xml['ram'].DefinedTradeContact do
xml['ram'].PersonName person_name
end
end
xml['ram'].PostalTradeAddress do
xml['ram'].PostcodeCode postal_code
xml['ram'].LineOne street1
Expand All @@ -53,3 +59,5 @@ def to_xml(xml, exclude_tax: false, version: 2)
end
end
end

# assert_match(%r{<ram:DefinedTradeContact>\s*<ram:PersonName>Max Mustermann</ram:PersonName>\s*</ram:DefinedTradeContact>}, xml)
2 changes: 2 additions & 0 deletions test/invoice_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ def make_de_invoice
)
buyer = TradeParty.new(
name: 'Depfu inc',
person_name: 'Max Mustermann',
street1: 'Quickbornstr. 46',
city: 'Hamburg',
postal_code: '20253',
Expand Down Expand Up @@ -596,6 +597,7 @@ def test_invoice_object_extensions
xml = invoice.to_xml(version: 2)

assert_match(/<ram:PaymentReference>#{invoice.payment_reference}<\/ram:PaymentReference>/, xml)
assert_match(%r{<ram:DefinedTradeContact>\s*<ram:PersonName>Max Mustermann</ram:PersonName>\s*</ram:DefinedTradeContact>}, xml)
end
end
end