Skip to content

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jul 23, 2025

Context

image

How did you test your changes?

local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Docs: Describe usage of non-ASCII characters in the sheet names #1313

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba requested a review from qunabu July 23, 2025 12:12
@sequba sequba self-assigned this Jul 23, 2025
@sequba sequba merged commit 6eb679a into develop Aug 5, 2025
25 checks passed
@sequba sequba deleted the feature/issue-1313 branch August 5, 2025 11:24
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (f7e11eb) to head (9dfc2a9).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1525   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14523           
  Branches      3169     3169           
========================================
  Hits         14120    14120           
  Misses         396      396           
  Partials         7        7           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Aug 5, 2025

Performance comparison of head (9dfc2a9) vs base (f7e11eb)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 506.88 |  505.1 | -0.35%
                                      Sheet B | 164.62 | 162.18 | -1.48%
                                      Sheet T | 143.85 | 143.02 | -0.58%
                                Column ranges | 506.91 | 507.52 | +0.12%
Sheet A:  change value, add/remove row/column |  13.53 |  13.42 | -0.81%
 Sheet B: change value, add/remove row/column | 121.77 | 121.74 | -0.02%
                   Column ranges - add column | 146.52 | 149.23 | +1.85%
                Column ranges - without batch | 442.89 | 434.43 | -1.91%
                        Column ranges - batch |    111 | 108.44 | -2.31%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants