BE-264: HashQL: Rename SROA to ForwardSubstitution for better semantic clarity

[indietyp]

🌟 What is the purpose of this PR?

Rename the SROA (Scalar Replacement of Aggregates) transformation pass to ForwardSubstitution to better reflect its actual functionality. This pass resolves place operands to their ultimate sources by tracing data dependencies through assignments, projections, and block parameters.

🔍 What does this change?

• Renames Sroa class to ForwardSubstitution across the codebase
• Updates documentation to clarify that this pass performs forward substitution of values through data dependencies
• Renames the test suite from mir/pass/transform/sroa to mir/pass/transform/forward-substitution
• Renames cp module to copy_propagation for consistency and clarity
• Updates benchmarks to use the new class name
• Improves documentation to better explain the differences between CopyPropagation and ForwardSubstitution

🛡 What tests cover this?

Existing tests have been preserved and renamed to match the new terminology.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

• does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

• are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

• do not affect the execution graph

[cursor]

PR Summary

Modernizes MIR transform naming and references for clarity and consistency.

• Replace Sroa with ForwardSubstitution across code, compiletest suites, outputs/headers, and registration
• Update pipelines and benches to run ForwardSubstitution (including criterion group rename and pipeline ordering)
• Rename transform::cp to transform::copy_propagation and adjust imports (e.g., propagate_block_params) and tests/snapshot paths
• Revise docs/comments to reference forward substitution (e.g., callgraph, inst_simplify) and clarify relation to CopyPropagation
• Add new mir/tests/ui/pass/forward_substitution snapshots and retire sroa ones

^{Written by Cursor Bugbot for commit 0fc7994. This will update automatically on new commits. Configure here.}

[indietyp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• BE-271: HashQL: Implement PostInline pass #8240
• BE-269: HashQL: Move PreInline out into Canonicalization pass #8239
• BE-268: HashQL: Rename PreInlining to PreInline for consistency #8238
• BE-270: HashQL: Optimize empty tuples to unit constants in MIR #8237
• BE-197: Implement MIR inline pass for HashQL #8236
• BE-267: Use bump scopes instead of full resets across transformation passes #8234
• BE-266: HashQL: Implement PreInlining pass for MIR optimization #8233
• BE-265: HashQL: Make CopyPropagation aware of local re-assignments #8231
• BE-264: HashQL: Rename SROA to ForwardSubstitution for better semantic clarity #8230 👈 (View in Graphite)
• BE-263: HashQL: add body! macro for declarative MIR construction in tests #8229
• BE-261: HashQL: Implement Administrative Reduction pass for MIR #8227
• BE-262: HashQL: Do not intern empty slices #8223
• BE-260: HashQL: Switch to bump allocator with scoping support #8218
• BE-259: HashQL: Add benchmarks for type system operations #8216
• BE-227: HashQL: Implement call graph analysis for MIR #8214
• BE-258: HashQL: Add Changed enum to track MIR transformation pass modifications #8210
• BE-255: HashQL: Implement Copy Propagation (CP) pass for MIR #8207
• BE-231: HashQL: Add InstSimplify pass for MIR instruction simplification and constant folding #8206
• BE-254: Add CodSpeed benchmarking for HashQL MIR transformation passes #8204
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.78%. Comparing base (9530312) to head (0fc7994).

Additional details and impacted files

@@                              Coverage Diff                              @@
##           bm/be-263-hashql-implement-mir-builder-macro    #8230   +/-   ##
=============================================================================
  Coverage                                         59.78%   59.78%           
=============================================================================
  Files                                              1066     1066           
  Lines                                            106191   106191           
  Branches                                           4478     4478           
=============================================================================
  Hits                                              63488    63488           
  Misses                                            41963    41963           
  Partials                                            740      740           

Flag	Coverage Δ
rust.hashql-compiletest	46.65% <ø> (ø)
rust.hashql-mir	87.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[augmentcode]

🤖 Augment PR Summary

Summary: Renames the MIR transform pass formerly called SROA to ForwardSubstitution to better match what the pass actually does (resolving place operands to their ultimate sources via data-dependency tracing).

Changes:

• Rename pass implementation and public exports (Sroa �e2 ForwardSubstitution) and update module wiring in hashql_mir::pass::transform.
• Expand/adjust docs to describe forward substitution behavior and how it combines with DSE to enable SROA-like aggregate decomposition.
• Rename cp module to copy_propagation and update internal imports (e.g., propagate_block_params) accordingly.
• Update compiletest suites: add/rename suite to mir/pass/transform/forward-substitution and run it in the MIR pipeline before InstSimplify.
• Update MIR benchmarks to use ForwardSubstitution and rename benchmark group from sroa to forward_substitution.
• Migrate/rename UI tests and snapshots from sroa/cp directories to forward_substitution/copy_propagation.

Technical Notes: This is primarily a semantic rename and documentation clarification; functional behavior should remain the same, with ForwardSubstitution positioned as the more comprehensive propagation pass vs CopyPropagation.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

[codspeed-hq]

CodSpeed Performance Report

Merging #8230 will degrade performance by 13.38%

_{Comparing bm/be-264-hashql-rename-sroa-to-projectionforwarding (0fc7994) with bm/be-263-hashql-implement-mir-builder-macro (b7fd7d0)¹}

Summary

❌ 1 (👁 1) regression
✅ 13 untouched
🆕 3 new

Benchmarks breakdown

	Benchmark	BASE	HEAD	Efficiency
🆕	linear	N/A	8 µs	N/A
🆕	diamond	N/A	16.7 µs	N/A
👁	diamond	6.5 µs	7.5 µs	-13.38%
🆕	complex	N/A	22.8 µs	N/A

Footnotes

1. No successful run was found on bm/be-263-hashql-implement-mir-builder-macro (9530312) during the generation of this report, so f01101c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩