Add a merge queue trigger #796
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
requested changes
Aug 28, 2025
| = ykeyValuesFilt [] | ||
| [ "push" ~> branches | ||
| , "pull_request" ~> branches | ||
| ] |
Collaborator
There was a problem hiding this comment.
Do just
toYaml GitHubOn {..}
| null ghBranches
= ylistFilt [] ["push", "pull_request","merge_queue"]
| otherwise
= ykeyValuesFilt []
[ "push" ~> branches
, "pull_request" ~> branches
, "merge_queue" ~> branches
]I don't see a reason to not simply always enable merge_queue.
And I especially don't like that merge_queue with branches doesn't configure branches.
Contributor
Author
There was a problem hiding this comment.
Right, that's a simpler change. I was under the impression that the merge_group trigger had no branches filter, since it's not documented anywhere
Collaborator
There was a problem hiding this comment.
It's unclear. The GHA YAML doesn't have proper schema, and the documentation is sparse and spread out. The docs are bad.
Contributor
Author
There was a problem hiding this comment.
It seems to work fine with the branches filter on well-typed/hs-bindgen#1025
Contributor
Author
There was a problem hiding this comment.
Alright, I've updated the PR
jorisdral
force-pushed
the
jdral/merge-group-trigger
branch
from
c59cfc2 to
9a61747
Compare
phadej
approved these changes
Aug 28, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phadej I hope the changes I've made make sense. I've also added a new golden test. I've not yet added a changelog entry