-
-
Notifications
You must be signed in to change notification settings - Fork 410
Add code action to introduce _ in numeric literals
#4716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code action to introduce _ in numeric literals
#4716
Conversation
fendor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution, this looks great to me!
Waiting for another review by @drsooch who is the maintainer of this plugin :)
plugins/hls-alternate-number-format-plugin/src/Ide/Plugin/Conversion.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: fendor <fendor@users.noreply.github.com>
|
No other reviews, so let's merge! Thank you for your contribution! |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4748. You may have to fix your CI before adding the pull request to the queue again. |
|
Ok, this merge queue doesnt seem to work how I would expect it to :) |
Closes #4650
This ended up being a bigger change than I intended. Some notes:
NumericUnderscoresis another extension, now the code action can add multiple of these.