Skip to content

Conversation

@crtschin
Copy link
Contributor

Closes #4650

This ended up being a bigger change than I intended. Some notes:

  • I followed the groupings in the linked issue per format.
  • I removed the regex-based approach for matching formats for simple string-matching. I didn't quite see an easy way to reuse it, as underscores can appear in any position in a literal. Makes it so we get the "fixing" functionality for semi-free.
    • I did reuse the regex's in the tests.
  • NumericUnderscores is another extension, now the code action can add multiple of these.

@crtschin crtschin requested a review from drsooch as a code owner August 30, 2025 12:30
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution, this looks great to me!

Waiting for another review by @drsooch who is the maintainer of this plugin :)

Co-authored-by: fendor <fendor@users.noreply.github.com>
@fendor fendor added the status: needs review This PR is ready for review label Sep 2, 2025
@fendor fendor added the merge me Label to trigger pull request merge label Oct 29, 2025
@fendor
Copy link
Collaborator

fendor commented Oct 29, 2025

No other reviews, so let's merge! Thank you for your contribution!

@mergify mergify bot added the queued label Oct 29, 2025
mergify bot added a commit that referenced this pull request Oct 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #4748.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Oct 29, 2025
@fendor
Copy link
Collaborator

fendor commented Oct 29, 2025

Ok, this merge queue doesnt seem to work how I would expect it to :)

@fendor fendor merged commit 7d5bb28 into haskell:master Oct 29, 2025
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dequeued merge me Label to trigger pull request merge status: needs review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add code action to introduce _ in number literals

2 participants