Make sclack installable from pip in a more universal fashion #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the app.py and config.json files within the sclack package and updated the setup.py to use the refactored entrypoint to start the script. This should make the sclack application installable from pip. and usable via the commandline as “sclack”
haskellcamargo
approved these changes
Mar 14, 2019
|
you also need to update tests/test_api.py diff --git c/tests/test_api.py i/tests/test_api.py
index 952088a..a57272f 100644
--- c/tests/test_api.py
+++ i/tests/test_api.py
@@ -1,5 +1,5 @@
from sclack.quick_switcher import remove_diacritic
-from app import ask_for_token
+from sclack.app import ask_for_token
from slackclient import SlackClient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the app.py and config.json files within the sclack package and updated the setup.py to use the refactored entrypoint to start the script.
This should make the sclack application installable from pip. and usable via the commandline as “sclack”