Upgrade Rustc to 1.88.0 (#818)

<!-- The PR description should answer 2 (maybe 3) important questions:
-->

### What

New version comes with a bunch of useful lints for detecting enums with
large size discrepencies, upgrade and fix the suggestions.

Author: danieljharvey

.github/workflows/ship.yaml

@@ -41,8 +41,10 @@ jobs:
           LOADED_IMAGE=$(docker load < result | awk -F': ' '{print $2}')
           echo "image=$LOADED_IMAGE" >> $GITHUB_OUTPUT
           echo "Loaded image: $LOADED_IMAGE"
+
       - name: Scan Docker Image with gokakashi
         uses: shinobistack/gokakashi-action@v0.2.0
+        continue-on-error: true
         with:
           image: ${{ steps.load-image.outputs.image }}
           labels: agentKey=${{ github.run_id }}-${{ matrix.target }}

changelog.md

@@ -305,7 +305,6 @@
   and will not write the introspection result to file if the configuration file is already up to date.
   ([#362](https://github.com/hasura/ndc-postgres/pull/362))
 - A few fields in the configuration format has been changed:
-
   - `configureOptions` was renamed to `introspectionOptions`
   - `connectionUri`, `poolSettings` and `isolationLevel` are now nested under `connectionSettings`
   - `mutationsVersion` was moved from `configureOptions` to the top-level

crates/cli/src/lib.rs

@@ -54,7 +54,7 @@ pub async fn run(command: Command, context: Context<impl Environment>) -> anyhow
         Command::Update => update(context).await?,
         Command::Upgrade { dir_from, dir_to } => upgrade(dir_from, dir_to).await?,
         Command::NativeOperation(cmd) => native_operations::run(cmd, context).await?,
-    };
+    }
     Ok(())
 }
 

crates/cli/src/native_operations.rs

@@ -63,7 +63,7 @@ pub async fn run(command: Command, context: Context<impl Environment>) -> anyhow
         Command::Delete { name, kind } => {
             delete(context, name, kind).await?;
         }
-    };
+    }
     Ok(())
 }
 
@@ -99,7 +99,7 @@ async fn list(context: Context<impl Environment>) -> anyhow::Result<()> {
                 println!("- {}", native_operation.0);
             }
         }
-    };
+    }
     Ok(())
 }
 
@@ -250,7 +250,7 @@ async fn create(
                 }
             }
         }
-    };
+    }
 
     // We write the configuration including the new Native Operation to file.
     configuration::write_parsed_configuration(configuration, context.context_path.clone()).await?;

crates/configuration/src/metrics.rs

@@ -6,6 +6,7 @@ use crate::VersionTag;
 
 /// The collection of configuration-related metrics exposed through the `/metrics` endpoint.
 #[derive(Debug, Clone)]
+#[allow(clippy::struct_field_names)]
 pub struct Metrics {
     configuration_version_3: IntGauge,
     configuration_version_4: IntGauge,

crates/configuration/src/version3/mod.rs

@@ -646,14 +646,14 @@ pub async fn write_parsed_configuration(
                         file: file.clone(),
                     },
                 )?;
-            };
+            }
 
             let native_query_file = out_dir.as_ref().to_owned().join(file);
             if let Some(native_query_sql_dir) = native_query_file.parent() {
                 fs::create_dir_all(native_query_sql_dir).await?;
-            };
+            }
             fs::write(native_query_file, String::from(sql.clone())).await?;
-        };
+        }
     }
 
     // create the jsonschema file

crates/configuration/src/version4/mod.rs

@@ -346,14 +346,14 @@ pub async fn write_parsed_configuration(
                         file: file.clone(),
                     },
                 )?;
-            };
+            }
 
             let native_query_file = out_dir.as_ref().to_owned().join(file);
             if let Some(native_query_sql_dir) = native_query_file.parent() {
                 fs::create_dir_all(native_query_sql_dir).await?;
-            };
+            }
             fs::write(native_query_file, String::from(sql.clone())).await?;
-        };
+        }
     }
 
     // create the jsonschema file

crates/configuration/src/version4/native_operations.rs

@@ -180,7 +180,6 @@ pub async fn oids_to_typenames(
             if info.schema_name == schema_name && info.type_name == type_name {
                 oids_map.insert(oid, scalar_type_name.clone());
                 found = true;
-                continue;
             }
         }
 

crates/configuration/src/version5/mod.rs

@@ -387,14 +387,14 @@ pub async fn write_parsed_configuration(
                         file: file.clone(),
                     },
                 )?;
-            };
+            }
 
             let native_query_file = out_dir.as_ref().to_owned().join(file);
             if let Some(native_query_sql_dir) = native_query_file.parent() {
                 fs::create_dir_all(native_query_sql_dir).await?;
-            };
+            }
             fs::write(native_query_file, String::from(sql.clone())).await?;
-        };
+        }
     }
     for native_query_sql in parsed_config
         .metadata
@@ -414,14 +414,14 @@ pub async fn write_parsed_configuration(
                         file: file.clone(),
                     },
                 )?;
-            };
+            }
 
             let native_query_file = out_dir.as_ref().to_owned().join(file);
             if let Some(native_query_sql_dir) = native_query_file.parent() {
                 fs::create_dir_all(native_query_sql_dir).await?;
-            };
+            }
             fs::write(native_query_file, String::from(sql.clone())).await?;
-        };
+        }
     }
 
     // create the jsonschema file

crates/configuration/src/version5/native_operations.rs

@@ -186,7 +186,6 @@ pub async fn oids_to_typenames(
             if info.schema_name == schema_name && info.type_name == type_name {
                 oids_map.insert(oid, scalar_type_name.clone());
                 found = true;
-                continue;
             }
         }