started new component for using external content such embedded iframes #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Currently there is no authoring component for embedding external content from ad networks or social media.
Twitter Embed
Youtube Embed
Does this close any currently open issues?
No. I've mentioned the issue in the past during the water-cooler and Gaston has also faced issues embedding external content.
Any other comments?
I still don't have a strong grasp on the percli commands needed to create and update the components. Could not find the docs that really explain the process. So I used
percli create component externalto initialize the component sources, and updated the files underui.apps/src/main/content/jcr_root/apps/themecleanflex/components/externalmanuallyWhere has this been tested?
Localhost
Browser (version):
Firefox 78.12.0esr (mac)
Chrome 92.0.4515.131 (mac)