Skip to content

Conversation

@cthtrifork
Copy link

@cthtrifork cthtrifork commented Dec 10, 2025

This solves #19

@antheas
Copy link
Collaborator

antheas commented Dec 10, 2025

Mmmm. Can you try to pull the skopeo command outside? Then people can do podman login in their action runner and it will work. I am afraid this might cause regressions and it only applies to the github registry

@cthtrifork
Copy link
Author

Mmmm. Can you try to pull the skopeo command outside? Then people can do podman login in their action runner and it will work. I am afraid this might cause regressions and it only applies to the github registry

Would it not be a big refactor as you are calling sudo podman run multiple times in your action.yaml ?
This is the reason i added it inside the 3_chunk.sh script but also added environment variable checks to not break existing calls.

I agreed it is limited to the github registry and I could add custom inputs to solve this.

The easiest way to solve your requirement would be probably inject the auth file instead - would that be preferable or am I missing out on something

@antheas
Copy link
Collaborator

antheas commented Dec 10, 2025

The skopeo command just downloads the manifest file. If you pull it outside the podman script it will be able to access the creds of your action and will work. You can also opt to add an action parameter that allows you to specify a path for the manifest and if it exists skip the skopeo call

@cthtrifork
Copy link
Author

I tried implementing the registry_auth_file, but I can change it again to volume mount a previous manifest file which has been pulled outside your action. The volume mount path would then be a input action

@antheas
Copy link
Collaborator

antheas commented Dec 10, 2025

Actually the way you did it might be good enough. Does it work?

@cthtrifork
Copy link
Author

Just tested it. It works!

@antheas
Copy link
Collaborator

antheas commented Dec 10, 2025

Does it work if the auth file does not exist?

@cthtrifork
Copy link
Author

I think you are right. I will test more scenarios. I forgot that volume mounts only create nonexisting directories but not nonexisting files

@cthtrifork
Copy link
Author

@antheas bash was being unfriendly but I have tested multiple scenaries including happy path, non existing auth file etc.

@cthtrifork
Copy link
Author

cthtrifork commented Dec 11, 2025

Let me know if you prefer a rebase or you are just going to squash

@cthtrifork
Copy link
Author

@antheas What do you prefer? or do you want a different approach altogether. Right now I am using my fork but I would like to use upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants