-
Notifications
You must be signed in to change notification settings - Fork 9
Support skopeo auth when inspecting prev-ref #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Mmmm. Can you try to pull the skopeo command outside? Then people can do podman login in their action runner and it will work. I am afraid this might cause regressions and it only applies to the github registry |
Would it not be a big refactor as you are calling I agreed it is limited to the github registry and I could add custom inputs to solve this. The easiest way to solve your requirement would be probably inject the auth file instead - would that be preferable or am I missing out on something |
|
The skopeo command just downloads the manifest file. If you pull it outside the podman script it will be able to access the creds of your action and will work. You can also opt to add an action parameter that allows you to specify a path for the manifest and if it exists skip the skopeo call |
|
I tried implementing the registry_auth_file, but I can change it again to volume mount a previous manifest file which has been pulled outside your action. The volume mount path would then be a input action |
|
Actually the way you did it might be good enough. Does it work? |
|
Just tested it. It works! |
|
Does it work if the auth file does not exist? |
|
I think you are right. I will test more scenarios. I forgot that volume mounts only create nonexisting directories but not nonexisting files |
|
@antheas bash was being unfriendly but I have tested multiple scenaries including happy path, non existing auth file etc. |
|
Let me know if you prefer a rebase or you are just going to squash |
|
@antheas What do you prefer? or do you want a different approach altogether. Right now I am using my fork but I would like to use upstream. |
This solves #19