This repository was archived by the owner on Sep 1, 2023. It is now read-only.
Clean up reference to varray, darray, and HH_FIXME #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update only those tests that fail the typechecker. Rest of the tests will be fixed in the next commit.
Begone you imprecise blunt hammer!
There is no such runner, so the task waits forever to start. Whoops!
Hhvm 4.128 does not support unfixme'd UNSAFE_CAST<Ta, Tb>() calls. Bumping to 4.153 to see if that version does. If it doesn't, will bump to 4.168.
Contributor
Author
|
The tests don't want to run here... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58
fixes #61
Fixes:
UntypedArraySpec. It was private and thearraytype is impossible to spell (both in the typechecker and in the runtime) anyway.varrayordarraytype is encountered inTypeSpec\of<T>()or its type structure based friends, they are treated asvecanddictrespectively.varray_or_darraytype is encountered, an UnsupportedTypeException is thrown.HH_FIXME/HH_IGNORE_ERRORdirectives an replaces them withHH\FIXME\UNSAFE_CAST<Ta, Tb>(...)where needed.