-
-
Notifications
You must be signed in to change notification settings - Fork 244
HSEARCH-5426 Adjust the count aggregation DSL #4719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marko-bekhta
merged 1 commit into
hibernate:main
from
marko-bekhta:feat/HSEARCH-5426-Adjust-the-count-aggregation-DSL
Jul 28, 2025
Merged
HSEARCH-5426 Adjust the count aggregation DSL #4719
marko-bekhta
merged 1 commit into
hibernate:main
from
marko-bekhta:feat/HSEARCH-5426-Adjust-the-count-aggregation-DSL
Jul 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3806345
to
1e9f309
Compare
yrodiere
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, but LTGM overall. Thanks!
...ne/src/main/java/org/hibernate/search/engine/search/aggregation/spi/AggregationTypeKeys.java
Outdated
Show resolved
Hide resolved
...nate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchCountAggregation.java
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_search-dsl-aggregation.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_search-dsl-aggregation.adoc
Outdated
Show resolved
Hide resolved
...c/main/java/org/hibernate/search/engine/search/aggregation/dsl/CountAggregationKindStep.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/hibernate/search/engine/search/aggregation/dsl/CountAggregationKindStep.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/hibernate/search/engine/search/aggregation/dsl/CountAggregationKindStep.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/hibernate/search/engine/search/aggregation/dsl/CountAggregationKindStep.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/hibernate/search/engine/search/aggregation/spi/CountAggregationBuilder.java
Outdated
Show resolved
Hide resolved
1e9f309
to
4e21549
Compare
4e21549
to
95ecbab
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-5426
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.