-
Notifications
You must be signed in to change notification settings - Fork 14
docs: update Helm chart README for Hiero Block Node installation and configuration #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…configuration This update revises the Helm chart README for the Hiero Block Node to provide clearer installation guidance and improved troubleshooting instructions. Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement contribution.
Some suggestions.
Also you should run ./gradlew spotlessApply to have the doc formatted otherwise we can't merge
charts/block-node-server/README.md
Outdated
| ```bash | ||
| helm template --name-template bn-release block-node-server/ --dry-run --output-dir out | ||
| export RELEASE="bn-release" # bn-release is short for block-node-release | ||
| export VERSION="0.23.0-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it to latest GA versions for stability reasons
| export VERSION="0.23.0-SNAPSHOT" | |
| export VERSION="0.22.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are changing this value with the version bump automatically to the latest SNAPSHOT, we need to improve the Release Automation to fix this permanently. I belive @deshmukhpranali already created an issue for use to make that improvement.
AlfredoG87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 💯
Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
|
@deshmukhpranali you will need to run |
…methods Add separate sections for local charts and OCI registry based upgrade paths. Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
d8e6956 to
9cc805e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1838 +/- ##
============================================
+ Coverage 80.65% 80.67% +0.01%
+ Complexity 1180 1179 -1
============================================
Files 127 127
Lines 5553 5553
Branches 591 591
============================================
+ Hits 4479 4480 +1
+ Misses 803 801 -2
- Partials 271 272 +1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This update revises the Helm chart README for the Hiero Block Node to provide clearer installation guidance and improved troubleshooting instructions.
Reviewer Notes
All instructions and commands in the updated README have been re-reviewed, except custom configuration.
Related Issue(s) fixes #1811