Skip to content

Conversation

@deshmukhpranali
Copy link

This update revises the Helm chart README for the Hiero Block Node to provide clearer installation guidance and improved troubleshooting instructions.

Reviewer Notes

All instructions and commands in the updated README have been re-reviewed, except custom configuration.

Related Issue(s) fixes #1811

…configuration

This update revises the Helm chart README for the Hiero Block Node to provide clearer installation guidance and improved troubleshooting instructions.


Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
@deshmukhpranali deshmukhpranali requested review from a team as code owners November 6, 2025 16:02
@Nana-EC Nana-EC added Block Node Issues/PR related to the Block Node. Documentation Issues/PR related to documentation labels Nov 7, 2025
@Nana-EC Nana-EC added this to the 0.23.0 milestone Nov 7, 2025
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement contribution.
Some suggestions.

Also you should run ./gradlew spotlessApply to have the doc formatted otherwise we can't merge

```bash
helm template --name-template bn-release block-node-server/ --dry-run --output-dir out
export RELEASE="bn-release" # bn-release is short for block-node-release
export VERSION="0.23.0-SNAPSHOT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it to latest GA versions for stability reasons

Suggested change
export VERSION="0.23.0-SNAPSHOT"
export VERSION="0.22.1"

Copy link
Contributor

@AlfredoG87 AlfredoG87 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are changing this value with the version bump automatically to the latest SNAPSHOT, we need to improve the Release Automation to fix this permanently. I belive @deshmukhpranali already created an issue for use to make that improvement.

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 💯

deshmukhpranali and others added 2 commits November 7, 2025 18:44
Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
@hiero-ledger hiero-ledger deleted a comment from deshmukhpranali Nov 7, 2025
@AlfredoG87
Copy link
Contributor

@deshmukhpranali you will need to run ./gradlew spotlessApply in order to pass the StyleCheck step on "PR Checks" CI Gate.

@AlfredoG87 AlfredoG87 modified the milestones: 0.23.0, 0.24.0 Nov 14, 2025
…methods

Add separate sections for local charts and OCI registry based upgrade paths.

Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
Signed-off-by: Pranali Deshmukh <pranali.deshmukh@swirldslabs.com>
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff              @@
##               main    #1838      +/-   ##
============================================
+ Coverage     80.65%   80.67%   +0.01%     
+ Complexity     1180     1179       -1     
============================================
  Files           127      127              
  Lines          5553     5553              
  Branches        591      591              
============================================
+ Hits           4479     4480       +1     
+ Misses          803      801       -2     
- Partials        271      272       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Block Node Issues/PR related to the Block Node. Documentation Issues/PR related to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Block Node Server README for accuracy and clarity

4 participants