-
Notifications
You must be signed in to change notification settings - Fork 177
chore: Use dispatch's FeeCharging
strategy in HandleContext
#21776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21776 +/- ##
============================================
+ Coverage 71.83% 71.87% +0.03%
- Complexity 24599 24636 +37
============================================
Files 2666 2669 +3
Lines 103930 104029 +99
Branches 10872 10889 +17
============================================
+ Hits 74662 74774 +112
+ Misses 25229 25212 -17
- Partials 4039 4043 +4 ... and 56 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Description:
HandleContext.tryToCharge()
fromFeeAccumulator
toFeeCharging
#21775