Skip to content

Conversation

@JivkoKelchev
Copy link
Contributor

@JivkoKelchev JivkoKelchev commented Dec 2, 2025

Description:
Cherry-pick of #22193 to release/0.69
Cherry-pick of #22487 to release/0.69

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ade (#22193)

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
(cherry picked from commit 5d86477)
@JivkoKelchev JivkoKelchev added this to the v0.69 milestone Dec 2, 2025
@JivkoKelchev JivkoKelchev self-assigned this Dec 2, 2025
@lfdt-bot
Copy link

lfdt-bot commented Dec 2, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@JivkoKelchev JivkoKelchev marked this pull request as ready for review December 2, 2025 08:45
@JivkoKelchev JivkoKelchev requested review from a team as code owners December 2, 2025 08:45
@codacy-production
Copy link

codacy-production bot commented Dec 2, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 93.55%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8d5bb4d) 105363 78853 74.84%
Head commit (bf91e33) 105415 (+52) 78903 (+50) 74.85% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22373) 62 58 93.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...roducers/formats/SelfNodeAccountIdManagerImpl.java 90.24% 2 Missing and 2 partials ⚠️
.../com/hedera/node/app/blocks/BlockStreamModule.java 0.00% 1 Missing ⚠️
...pp/workflows/handle/record/SystemTransactions.java 66.66% 1 Missing ⚠️

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.69   #22373      +/-   ##
==================================================
+ Coverage           70.98%   70.99%   +0.01%     
- Complexity          24699    24712      +13     
==================================================
  Files                2704     2705       +1     
  Lines              105460   105512      +52     
  Branches            11108    11111       +3     
==================================================
+ Hits                74859    74907      +48     
- Misses              26561    26563       +2     
- Partials             4040     4042       +2     
Files with missing lines Coverage Δ Complexity Δ
...-app/src/main/java/com/hedera/node/app/Hedera.java 52.85% <100.00%> (+0.20%) 51.00 <0.00> (ø)
...cks/impl/streaming/FileAndGrpcBlockItemWriter.java 62.50% <100.00%> (ø) 5.00 <0.00> (ø)
...app/blocks/impl/streaming/FileBlockItemWriter.java 41.98% <100.00%> (+0.32%) 21.00 <0.00> (ø)
...roducers/formats/BlockRecordWriterFactoryImpl.java 100.00% <100.00%> (ø) 5.00 <2.00> (+1.00)
...impl/producers/formats/v6/BlockRecordWriterV6.java 80.14% <100.00%> (+0.14%) 24.00 <0.00> (ø)
...app/workflows/standalone/TransactionExecutors.java 85.24% <100.00%> (+0.37%) 8.00 <0.00> (ø)
...rvice/token/impl/ReadableStakingInfoStoreImpl.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
.../com/hedera/node/app/blocks/BlockStreamModule.java 84.21% <0.00%> (ø) 7.00 <0.00> (ø)
...pp/workflows/handle/record/SystemTransactions.java 62.30% <66.66%> (-0.06%) 53.00 <0.00> (ø)
...roducers/formats/SelfNodeAccountIdManagerImpl.java 90.24% <90.24%> (ø) 11.00 <11.00> (?)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ibankov
ibankov previously approved these changes Dec 3, 2025
Copy link
Contributor

@ibankov ibankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@lukasz-hashgraph lukasz-hashgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Co-authored-by: Derek Riley <derek.riley@swirldslabs.com>
(cherry picked from commit 91953bd)
@JivkoKelchev JivkoKelchev changed the title feat: Cherry-pick (v69): Create file on disk with node account ID on freeze prepare upgrade feat: Cherry-pick (v69): Switch to new stream directory on post-upgrade setup Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants