-
Notifications
You must be signed in to change notification settings - Fork 186
fix: Add additional verification strategy for schedule delete facade calls #22461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lete proxy Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22461 +/- ##
============================================
- Coverage 74.13% 74.05% -0.08%
- Complexity 23562 23581 +19
============================================
Files 2551 2562 +11
Lines 96372 96529 +157
Branches 10216 10227 +11
============================================
+ Hits 71444 71485 +41
- Misses 21149 21253 +104
- Partials 3779 3791 +12
... and 53 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
gkozyryatskyy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
.../service/contract/impl/exec/systemcontracts/hss/deleteschedule/DeleteScheduleTranslator.java
Show resolved
Hide resolved
.../service/contract/impl/exec/systemcontracts/hss/deleteschedule/DeleteScheduleTranslator.java
Show resolved
Hide resolved
lukelee-sl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Added additional verification strategy covering the case when schedule was created with admin key different than contract id. Now we are able to delete the schedule from facade calls.
Related issue(s):
Fixes #22446
Notes for reviewer:
Checklist