Skip to content

Conversation

@stoyanov-st
Copy link
Contributor

Description:

Added additional verification strategy covering the case when schedule was created with admin key different than contract id. Now we are able to delete the schedule from facade calls.

Related issue(s):

Fixes #22446

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…lete proxy

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
@stoyanov-st stoyanov-st added this to the v0.70 milestone Dec 8, 2025
@stoyanov-st stoyanov-st self-assigned this Dec 8, 2025
@stoyanov-st stoyanov-st requested review from a team and tinker-michaelj as code owners December 8, 2025 14:21
@lfdt-bot
Copy link

lfdt-bot commented Dec 8, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Dec 8, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4f93776) 96256 75156 78.08%
Head commit (7d28f7d) 96432 (+176) 75228 (+72) 78.01% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22461) 22 22 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/hss/deleteschedule/DeleteScheduleTranslator.java 81.25% 0 Missing and 3 partials ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #22461      +/-   ##
============================================
- Coverage     74.13%   74.05%   -0.08%     
- Complexity    23562    23581      +19     
============================================
  Files          2551     2562      +11     
  Lines         96372    96529     +157     
  Branches      10216    10227      +11     
============================================
+ Hits          71444    71485      +41     
- Misses        21149    21253     +104     
- Partials       3779     3791      +12     
Files with missing lines Coverage Δ Complexity Δ
...mcontracts/hss/DispatchForResponseCodeHssCall.java 91.89% <100.00%> (+1.56%) 9.00 <2.00> (+2.00)
...s/hss/deleteschedule/DeleteScheduleTranslator.java 92.85% <81.25%> (-7.15%) 15.00 <6.00> (+5.00) ⬇️

... and 53 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Copy link
Contributor

@gkozyryatskyy gkozyryatskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoyanov-st stoyanov-st merged commit 29d212b into main Dec 10, 2025
81 of 82 checks passed
@stoyanov-st stoyanov-st deleted the fix-hip1215-schedule-delete-facade branch December 10, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate the behaviour of scheduleDelete facade call

5 participants