Skip to content

Conversation

@quiet-node
Copy link
Contributor

Description

This PR cherry picks "stop fetching transactions data when its not needed (#4598)"

Related issue(s)

Fixes #4553

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@quiet-node quiet-node added this to the 0.73 milestone Nov 18, 2025
@quiet-node quiet-node self-assigned this Nov 18, 2025
@quiet-node quiet-node requested review from a team as code owners November 18, 2025 16:46
@quiet-node quiet-node added the process Build, test and deployment-process related tasks label Nov 18, 2025
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Test Results

 20 files  ±0  269 suites  ±0   22m 3s ⏱️ -9s
778 tests ±0  774 ✅ ±0  4 💤 ±0  0 ❌ ±0 
794 runs  ±0  790 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 2eb1ada. ± Comparison against base commit 81dbf47.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit d0382bc into release/0.73 Nov 19, 2025
82 of 88 checks passed
@quiet-node quiet-node deleted the cherry-pick-#4598 branch November 19, 2025 16:13
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@               Coverage Diff                @@
##           release/0.73    #4625      +/-   ##
================================================
- Coverage         95.52%   95.51%   -0.01%     
================================================
  Files               127      127              
  Lines             20444    20437       -7     
  Branches           1760     1764       +4     
================================================
- Hits              19529    19521       -8     
- Misses              896      897       +1     
  Partials             19       19              
Flag Coverage Δ
config-service 98.81% <ø> (ø)
relay 90.92% <100.00%> (-0.01%) ⬇️
server 88.85% <ø> (ø)
ws-server 98.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts 94.22% <100.00%> (-0.06%) ⬇️
...rvices/ethService/accountService/AccountService.ts 96.55% <100.00%> (+0.01%) ⬆️
packages/relay/src/lib/types/mirrorNode.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

process Build, test and deployment-process related tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants