Skip to content

AlertIOS Fixes #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

AlertIOS Fixes #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28789ef
fix(readme): Fixed deprecated AlertIOS
Volksfeld Sep 10, 2019
18c6298
fix(readme): Fixed deprecated AlertIOS
Volksfeld Sep 10, 2019
00001ef
fix(readme): Fixed deprecated AlertIOS
Volksfeld Sep 10, 2019
27af64f
fix(FingerprintPopup.component.ios.js): Fixed deprecated AlertIOS
Volksfeld Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ In your `Info.plist`:
```javascript
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { AlertIOS } from 'react-native';
import { Alert } from 'react-native';
import FingerprintScanner from 'react-native-fingerprint-scanner';

class FingerprintPopup extends Component {
Expand All @@ -132,11 +132,11 @@ class FingerprintPopup extends Component {
.authenticate({ description: 'Scan your fingerprint on the device scanner to continue' })
.then(() => {
this.props.handlePopupDismissed();
AlertIOS.alert('Authenticated successfully');
Alert.alert('Authenticated successfully');
})
.catch((error) => {
this.props.handlePopupDismissed();
AlertIOS.alert(error.message);
Alert.alert(error.message);
});
}

Expand All @@ -158,7 +158,9 @@ import React, { Component } from 'react';
import PropTypes from 'prop-types';

import {
Alert,


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the extra line breaks here?

,
Image,
Text,
TouchableOpacity,
Expand Down Expand Up @@ -275,11 +277,11 @@ componentDidMount() {
.authenticate({ description: 'Scan your fingerprint on the device scanner to continue' })
.then(() => {
this.props.handlePopupDismissed();
AlertIOS.alert('Authenticated successfully');
Alert.alert('Authenticated successfully');
})
.catch((error) => {
this.props.handlePopupDismissed();
AlertIOS.alert(error.message);
Alert.alert(error.message);
});
}
```
Expand Down
6 changes: 3 additions & 3 deletions examples/src/FingerprintPopup.component.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { AlertIOS } from 'react-native';
import {Alert} from 'react-native';
import FingerprintScanner from 'react-native-fingerprint-scanner';

class FingerprintPopup extends Component {
Expand All @@ -10,11 +10,11 @@ class FingerprintPopup extends Component {
.authenticate({ description: 'Scan your fingerprint on the device scanner to continue' })
.then(() => {
this.props.handlePopupDismissed();
AlertIOS.alert('Authenticated successfully');
Alert.alert('Authenticated successfully');
})
.catch((error) => {
this.props.handlePopupDismissed();
AlertIOS.alert(error.message);
Alert.alert(error.message);
});
}

Expand Down