Strip query params #89
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling query parameters in URLs by stripping them before processing. The change ensures that URLs with cache-busting or other query strings (e.g., ?cache=123) are correctly parsed to extract branch names, file paths, and types.
Key changes:
- Added a
stripQueryhelper function to remove query parameters from URLs - Updated
getBranch,getFile, andgetTypefunctions to strip query parameters before processing - Added test coverage for query string handling in all three affected functions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/interpreter.js | Added stripQuery utility function and integrated it into getBranch, getFile, and getType functions to handle URLs with query parameters |
| test/interpreter.js | Added test cases for getBranch, getFile, and getType to verify query string handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.