fix(37047) Fix the observability links in the workspace #1252
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates routing paths from /workspace/link/ to /workspace/connector/ to align with the new routing structure. The changes ensure consistency between navigation logic in edge components and test expectations.
- Updated navigation paths in
MonitoringEdgeandDynamicEdgecomponents - Updated corresponding test assertions to match the new route pattern
- Added a new
useEffecthook to handle edge selection in the configuration panel controller
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MonitoringEdge.tsx | Changed navigation path from /workspace/link/ to /workspace/connector/ |
| MonitoringEdge.spec.cy.tsx | Updated test assertion to verify new /workspace/connector/ route |
| DynamicEdge.tsx | Changed navigation path from /workspace/link/ to /workspace/connector/ |
| DynamicEdge.spec.cy.tsx | Updated test assertion to verify new /workspace/connector/ route |
| ConfigurationPanelController.tsx | Added useEffect to open panel when an edge is selected |
| .github/workflows/trigger.md | Unrelated file trigger change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hivemq-edge-frontend/src/modules/Workspace/components/controls/ConfigurationPanelController.tsx
Show resolved
Hide resolved
hivemq-edge-frontend/src/modules/Workspace/components/controls/ConfigurationPanelController.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/37047/details/
The PR fixes a small bug in the
Workspace, where the navigation route to theObservabilitypanel for the connected entities was triggering a "Page Not Found" errorBefore
After