FIx #505 #511
Closed
FIx #505 #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good to me. I cannot reproduce the initial issue so it's difficult to test, have you been able to reproduce the issue described in #505 ? |
|
I think this one is a red herring, to be honest. I was able to reproduce it before the "fix" but then I started looking at the entire selection mechanism and using the debugger in Blender 4.4 and did #513, which I think fixes this and a lot more indirectly. I'm running the plugin with all my recent PRs applied and selections work well for me. |
|
Ok, should this PR still be merged or dropped in favor of #513? |
|
I say we drop it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #505. I think that the offscreen buffer wasn't ready when hover detection was attempted and that selecting directly the plane wasn't initializing things properly. Either way, I now cannot reproduce the issue: