-
-
Notifications
You must be signed in to change notification settings - Fork 152
Fix #50 by refactoring the selection mechanism #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rcarmo
wants to merge
65
commits into
hlorus:main
Choose a base branch
from
rcarmo:fix/50
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
f6ff723
Try to cycle through overlapping entities
rcarmo 165dda1
Debugging tasks
rcarmo 30bd0b5
Add safe_batch_for_shader wrapper to correctly handle parameters
rcarmo f91fb44
Revert "StateOps: Push an undo step if OP finishes from preselection"
hlorus b0b6fb3
[Ui] Change icon name
hlorus eda9ee6
go deeper on batch_for_shader replacement
rcarmo 42c529b
2 more batch_for_shader replacements
rcarmo 0c33451
correctly handle box selection coordinates (they're 2D, not 3D...)
rcarmo a5ce841
Make sure workplanes are rendered to the selection buffer
rcarmo 714b3dc
Try to prioritize occluded workplane edges (and allow workplanes to b…
rcarmo 479dda3
tweak tolerances
rcarmo 2cc1e1f
Tweak tolerances
rcarmo c073d78
Bonus: unregistration logging to catch errors during frequent restarts
rcarmo a238ab2
Linux testing
rcarmo e7b1079
linux: change loading order foor 4.4.1
rcarmo 4646366
handle case where preferences are not yet defined (like when debugging)
rcarmo 8efe77b
tweak launch tasks
rcarmo 929ea51
color constants
rcarmo f4b8e69
Create mock preferences object for fallback
rcarmo 125305f
constant cleanup
rcarmo 1ef413c
selection and drawing constants
rcarmo 33ee68a
more constant cleanup
rcarmo 302412b
More constant shuffling (remove circular import)
rcarmo 93f0b9a
Better handle unregistration so it doesn't crash upon debugger reload
rcarmo afacd7f
Remove workplane selection by plane
rcarmo 0710a92
Try to handle unregistration better for debugging scenarios
rcarmo 8710b8c
refactor: shader handling, instrumentation, selection workflow
rcarmo bcb0f8d
shared data: group items and helpers
rcarmo 0fa3940
tasks: fix Blender not syncing to debugger
rcarmo ee86353
imports: hoist
rcarmo 1f01dbe
imports: hoist
rcarmo 2174e0f
imports: keep inline
rcarmo 6b09465
refactor: move recalc_pointers to data_handling
rcarmo 245de38
imports: hoist
rcarmo dcf3b9b
imports: hoist
rcarmo f9f0142
refactor: selection behavior
rcarmo af94fa2
refactor: move make_coincident to data_handling
rcarmo 08f5d8b
shaders: use dedicated to type
rcarmo d372e04
refactor: break out solver constants
rcarmo 2a5266e
refactor: replace solver constants
rcarmo ba418f1
refactor: replace solver constants
rcarmo d3368c1
refactor: replace solver constants
rcarmo e666ace
refactor: replace solver constants
rcarmo 1cceaec
refactor: replace solver constants
rcarmo fd0a33a
refactor: replace solver constants
rcarmo c14e7bf
refactor: replace solver constants
rcarmo 2dd561b
refactor: missed an import
rcarmo 791be1f
fixes: typos, hoisted imports that generate loops
rcarmo d2ea427
refactor: hunt down and kill to_list's evil twin, typos
rcarmo eb8ad86
cleanups: global state
rcarmo 7636d2f
revert: global_data handling
rcarmo 3f32c4a
revert: more obvious global_data handling
rcarmo 170d570
refactor: use safe variants
rcarmo 8d7ce0a
logs: debugging
rcarmo 58d7c86
icon manager: checks and fallbacks
rcarmo 6dfd976
workplanes: do not render in sketch
rcarmo ffd2220
constants: hoist
rcarmo 782ce19
typo
rcarmo 92387e4
workplane: clarify visibility/rendering logic.
rcarmo c670d47
workplanes: ensure edges are not drawn inside sketch
rcarmo 41628dc
select: add logging
rcarmo 8a9706f
select: add logging
rcarmo 671ac24
Merge branch 'fix/50' of github.com:rcarmo/CAD_Sketcher into fix/50
rcarmo f415978
select: overlapping lines work
rcarmo 809b8b8
select: cleanup logging
rcarmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workplane is a 3d element so it should never be drawn when a sketch is active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, I think. I split those out into two separate calls but didn't update the comments... Can you see it in the selection buffer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i still see the black square in the selection buffer when a sketch is active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest push should fix that. I made the logic a bit more explicit. But I still need to go back and validate that overlapping selections work and hoist a few more constants.