Update CEF Version to 138.0.21 #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flutter 3.32 version runs abnormally, flutter 3.29 runs normally |
How so? What results did you find? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR could break older Flutter projects that have
main.ccandmy_application.ccsource files inlinux/and not inlinux/runner/as newly created Flutter projects do.I did not test this on Windows.
Windows may be broken before and/or after this change for all I know
This PR updates the CEF version used to the latest:
138.0.7204.101.There was only a small change to the function signature of
CefClient::OnBeforePopupthat prevented compilation with the newer version and needed to be updated in theWebviewHandlersubclass.It also includes a change to how GTK is linked in CMake: wavecommander@d62fa09.
I had problems getting it to link correctly and found that GTKMM is the official GTK C++ interface and switched to linking against that.
I installed
libgtkmm-3.0-dev libgtkmm-3.0-1t64 libgtk-3-dev libgtk-3-0t64on Ubuntu 24.04 in order to successfully build my Flutter project that used this as a dependency, but it is possible that not all of those were necessary or the list could be incomplete as well.