Skip to content

Fix: Remove listData from useEffect dependency to prevent infinite re… #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Remove listData from useEffect dependency to prevent infinite re… #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/components/Dropdown/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,18 @@ const DropdownComponent = React.forwardRef<IDropdownRef, DropdownProps<any>>(
useEffect(() => {
if (data && searchText.length === 0) {
const filterData = excludeData(data);
setListData([...filterData]);
// only update state when the filtered data actually differs to avoid infinite re-renders
if (!_isEqual(filterData, listData)) {
setListData([...filterData]);
}
}

if (searchText) {
// call the search handler when there is a search term
onSearch(searchText);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [data, searchText]);
// eslint-enable-next-line react-hooks/exhaustive-deps
}, [data, searchText, excludeData, listData]);

const eventOpen = () => {
if (!disable) {
Expand Down Expand Up @@ -300,7 +304,7 @@ const DropdownComponent = React.forwardRef<IDropdownRef, DropdownProps<any>>(
}
}
}
}, [autoScroll, data.length, listData, value, valueField]),
}, [autoScroll, data.length, value, valueField]), // to fix Maximum Depth Exceeded warning | removed listData from dependency array
200
);

Expand Down