-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add pie chart mode to energy devices graph #27282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add hide_compound_stats option to energy-devices-graph-card * Update src/panels/lovelace/cards/energy/hui-energy-devices-graph-card.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl> * format --------- Co-authored-by: Bram Kragten <mail@bramkragten.nl>
The device hierarchy is a bit of a problem here right? If you're rendering bars as a percentage of a whole, any energy under a hierarchy is going to be double (or more) counted if you're rendering it as a fraction of 100%. |
Yes but the circle doesn't need to represent 100% of the consumption. |
The idea of this card is to show you the top consumers and conflating end devices with compound ones like breakers just needlessly complicatesb it, imo. |
I guess I'm afraid "end device" vs "compound device" is not such a black and white distinction. Just because you have at least one child device under a device doesn't mean that it's superflouous, you could have many other loads under a parent that aren't otherwise tracked, and then you'll lose that monitoring. I fear if we punish users by removing features for enabling hierarchy we'll end up driving them back to whatever janky templates they were trying to use before we added this feature. |
Actually we could use this to show the total usage in the middle and then it would make a lot of sense to show the untracked part of parents like in the other chart. Only when they are enabled of course. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Add a sub-editor to hui-entity-editor * item styling
Not sure how to handle untracked energy now. The total in the middle will be more than the sum of the devices because untracked isn't included. But I'm afraid if I include it, it will take a lot of space in some cases and reduce the actually valuable data. |
I set a min height of 300. Could make it 400 like the other charts. |
src/panels/lovelace/cards/energy/hui-energy-devices-graph-card.ts
Outdated
Show resolved
Hide resolved
src/panels/lovelace/cards/energy/hui-energy-devices-graph-card.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Proposed change
Add a new mode to the energy devices graph with a universal transition animation
Screen.Recording.2025-10-01.at.16.15.35.mov
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: