-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix spelling: Change 'ip_adresses' to 'ip_addresses' in Matter integr… #27336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix spelling: Change 'ip_adresses' to 'ip_addresses' in Matter integr… #27336
Conversation
…ation - Fixed TypeScript interface property name (matter.ts) - Updated translation key reference (ha-device-info-matter.ts) - Corrected English translation text (en.json) - Improves code consistency and correct spelling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This touches MatterNodeDiagnostics, which also has a spelling issue in the core repository. You will need to open a pull request there first.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thank you for pointing this out! I understand now that this needs to be fixed at the source in the core repository first. I will:
I'll add a link to the core PR here once it's created. Should I keep this PR open or close it until the core fix is complete? |
Yes to all, in the end they will be merged at the same point when both are approved. :D Keep this one open and link the core pull request in this pull request. Then in core, link back to the frontend pull request. |
I've created the corresponding PR in the core repository to fix the typo at the source: home-assistant/core#153833 Once that's merged, I'll update this PR to match the corrected spelling. Thanks for catching this! |
…ation
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: