Skip to content

Conversation

lesliefdo08
Copy link
Contributor

@lesliefdo08 lesliefdo08 commented Oct 4, 2025

…ation

  • Fixed TypeScript interface property name (matter.ts)
  • Updated translation key reference (ha-device-info-matter.ts)
  • Corrected English translation text (en.json)
  • Improves code consistency and correct spelling

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

…ation

- Fixed TypeScript interface property name (matter.ts)
- Updated translation key reference (ha-device-info-matter.ts)
- Corrected English translation text (en.json)
- Improves code consistency and correct spelling
Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This touches MatterNodeDiagnostics, which also has a spelling issue in the core repository. You will need to open a pull request there first.

@home-assistant
Copy link

home-assistant bot commented Oct 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 5, 2025 10:27
@lesliefdo08
Copy link
Contributor Author

Thank you for pointing this out! I understand now that this needs to be fixed at the source in the core repository first.

I will:

  1. Create a PR in https://github.com/home-assistant/core to fix the ip_adresses typo in the Matter integration
  2. Wait for that PR to be merged
  3. Then update this frontend PR to match the corrected spelling

I'll add a link to the core PR here once it's created. Should I keep this PR open or close it until the core fix is complete?

@lesliefdo08 lesliefdo08 marked this pull request as ready for review October 6, 2025 07:28
@home-assistant home-assistant bot requested a review from silamon October 6, 2025 07:28
@silamon
Copy link
Contributor

silamon commented Oct 6, 2025

Thank you for pointing this out! I understand now that this needs to be fixed at the source in the core repository first.

I will:

1. Create a PR in https://github.com/home-assistant/core to fix the ip_adresses typo in the Matter integration

2. Wait for that PR to be merged

3. Then update this frontend PR to match the corrected spelling

I'll add a link to the core PR here once it's created. Should I keep this PR open or close it until the core fix is complete?

Yes to all, in the end they will be merged at the same point when both are approved. :D Keep this one open and link the core pull request in this pull request. Then in core, link back to the frontend pull request.

@lesliefdo08
Copy link
Contributor Author

I've created the corresponding PR in the core repository to fix the typo at the source: home-assistant/core#153833

Once that's merged, I'll update this PR to match the corrected spelling. Thanks for catching this!

@bramkragten bramkragten marked this pull request as draft October 6, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants