-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add menu item to copy config entry id #27394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can't those actions use a config entry selctor, instead of asking for the ID? For the vast majority of integrations this seems like it would be of no value, and would just be noise for the user. |
Yes you are right; the user can do it through the UI. I understand there's a need to balance between convenience and keeping things simple/intuitive. |
src/translations/en.json
Outdated
"entries": "{count} {count, plural,\n one {entry}\n other {entries}\n}", | ||
"no_devices_or_entities": "No devices or entities", | ||
"devices_without_subentry": "Devices that don't belong to a sub-entry", | ||
"copy": "Copy config entry ID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we shorten this to "Copy entry ID"?
Most languages don't shorten "configuration" as "config" so this gets pretty long:
- Konfigurationseintrag-ID kopieren (German)
- Copier l'ID d'entrée de configuration (French)
- Copiar ID de entrada de configuración (Spanish)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please short it even more: let's just call it Copy ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be specific to distinguish between device id and config entry id.
I think "Copy entry ID" is fine.
I think we need to think of where we want to have stuff like this, technical IDs of devices, areas, config entries, to be used in YAML etc, I think in this menu definitely is not the right place. It could maybe go into the system options dialog. |
` | ||
: nothing} | ||
<ha-md-menu-item @click=${this._handleCopy} graphic="icon"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this below the rename item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, easy change
Proposed change
Some integrations (e.g. telegram_bot, mealie, mastodon) have actions that required
config_entry_id
as a parameter.This change adds a new menu item in the integrations page to allow the user to get the value of the
config_entry_id
to use for actions.A toast is also displayed when the menu item is clicked.
Type of change
Example configuration
Not required.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: