Always display device name in entity picker

[abmantis]

Proposed change

Currently, when the entity name is the same as the device name (either by being the primary entity of the device or by having a custom friendly name set equal to the device name), the device name is not displayed in the entity picker. This makes it look like the entity does not belong to the device since it deviates from the others, and it is not clear for an user as to why.

For consistency, this PR makes the device name always visible.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[piitaya]

It was not displayed because it was duplicated information as the entity name is the same as device name. Not sure if displaying duplicated device name is better in term of UX.

[abmantis]

It was not displayed because it was duplicated information as the entity name is the same as device name. Not sure if displaying duplicated device name is better in term of UX.

Yeah, the name is the same but they have different contexts. Without it, it looks like the entity does not belong to any device, which is misleading and inconsistent.

I think users will understand why it has the same name on the device and entity, but not why it is missing a device on the entity.

[marcinbauer85]

👋
I do understand from where are you coming from with this. I think we should have this as a discussion point next week with a greater audience. This year we started to add more context everywhere in HA to provide more hierarchical information. The entity, target picker, dashboards, are just some where we made this better. This is outlier is due to the "magic" we do in the device page, which also needs a redesign.