-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Migrate favorite color dialog to bottom sheet and ha-wa-dialog #27432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Seems to be broken on devices with very small width, moreover on mobile it was a bottom sheet, maybe we should use |
|
Yes, please try to use the new bottom sheet component from Paul. |
|
@timmo001 I did some changes to the ha-bottom-sheet in my target picker PR, to be able to set max-width for example. If you want you can wait till this is merged |
|
Sounds good, I'll leave this for now |
|
Will close to not clutter the PRs while this is being worked on. |
|
@timmo001 target picker is merged |
|
Oh timing 😆 |
4ca1fce to
61238aa
Compare
|
Breaking change
Proposed change
to
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: