Skip to content

Conversation

@timmo001
Copy link
Member

@timmo001 timmo001 commented Oct 9, 2025

Breaking change

Proposed change

image image

to

image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@timmo001 timmo001 changed the title Wa dialog light color favorite Migrate favorite color dialog to ha-wa-dialog Oct 9, 2025
@timmo001 timmo001 marked this pull request as ready for review October 9, 2025 15:15
@wendevlin
Copy link
Member

Seems to be broken on devices with very small width, moreover on mobile it was a bottom sheet, maybe we should use ha-bottom-sheet here.

@marcinbauer85
Copy link
Member

Yes, please try to use the new bottom sheet component from Paul.

@wendevlin
Copy link
Member

@timmo001 I did some changes to the ha-bottom-sheet in my target picker PR, to be able to set max-width for example. If you want you can wait till this is merged

@timmo001 timmo001 marked this pull request as draft October 13, 2025 11:13
@timmo001
Copy link
Member Author

Sounds good, I'll leave this for now

@timmo001
Copy link
Member Author

Will close to not clutter the PRs while this is being worked on.

#27143

@timmo001 timmo001 closed this Oct 14, 2025
@wendevlin
Copy link
Member

@timmo001 target picker is merged

@timmo001
Copy link
Member Author

Oh timing 😆

@timmo001 timmo001 reopened this Oct 14, 2025
@timmo001 timmo001 force-pushed the wa-dialog-light-color-favorite branch from 4ca1fce to 61238aa Compare October 14, 2025 14:26
@timmo001 timmo001 changed the title Migrate favorite color dialog to ha-wa-dialog Migrate favorite color dialog to bottom sheet Oct 14, 2025
@timmo001 timmo001 changed the title Migrate favorite color dialog to bottom sheet Migrate favorite color dialog to bottom sheet and ha-wa-dialog Oct 14, 2025
@timmo001 timmo001 marked this pull request as ready for review October 15, 2025 08:40
@wendevlin
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants