Add new php-cpd commit hook #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new php-cs-fixer hook with new helpers
* 'master' of github.com:hootsuite/pre-commit-php:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
PHP Copy Paste Detector is a QA tool that can be used to find duplicate code. This adds a new pre-commit-php hook for calling
phpcpd.Implementation
This is fairly straightforward and also follows the general pattern of
php-cs-fixer. This will ONLY analyze the files that are staged for duplicate code, and not the entire project. A feature to scan the entire project could perhaps be added.Sample Output
Review
This was a little rushed, and the commit to both the README and hooks files have the entries from
php-mdin it. This should sort itself out in the merge, but if you'd like a tidier PR, please let me know.