Fix: TOTP Login Error Message and reload handling / split off #21 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralflang
changed the title
ralflang
commented
Jun 24, 2025
Member
Author
ralflang
left a comment
ralflang
left a comment
There was a problem hiding this comment.
Validated cases:
- No TOTP needed because API is not present (login granted with correct password)
- No TOTP needed because API says feature is disabled (login granted with correct password)
- No TOTP needed because mode is optional and user has not setup TOTP (login granted)
- TOTP needed and not offered (Login rejected)
- TOTP needed and offered (login granted with correct primary password)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off PR #21 to separate the TOTP related fixes from the login refactor.