-
Notifications
You must be signed in to change notification settings - Fork 0
Add syntax highlighting to benchmark page code blocks #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,8 @@ | |||||
| <meta charset="UTF-8"> | ||||||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||||||
| <title>json5-kotlin - JSON5 Implementation for Kotlin/JVM</title> | ||||||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/atom-one-dark.min.css"> | ||||||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/highlight.min.js"></script> | ||||||
| <script src="https://cdn.jsdelivr.net/npm/chart.js"></script> | ||||||
| <style> | ||||||
| body { | ||||||
|
|
@@ -98,9 +100,9 @@ | |||||
| font-size: 1.2em; | ||||||
| } | ||||||
| .code-block { | ||||||
| background: #2d3748; | ||||||
| color: #e2e8f0; | ||||||
| padding: 20px; | ||||||
| /* background: #2d3748; */ /* Theme will provide background */ | ||||||
| /* color: #e2e8f0; */ /* Theme will provide color */ | ||||||
|
Comment on lines
+103
to
+104
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] These commented-out CSS rules are no longer needed; removing them will clean up the stylesheet and reduce confusion.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| padding: 20px; /* This padding will be outside the themed code area */ | ||||||
| border-radius: 8px; | ||||||
| overflow-x: auto; | ||||||
| margin: 20px 0; | ||||||
|
|
@@ -289,68 +291,68 @@ <h2>JSON5 Features</h2> | |||||
| <h3><span class="icon">💬</span>Comments</h3> | ||||||
| <p>Both line comments <code>//</code> and block comments <code>/* */</code> are supported.</p> | ||||||
| <div class="code-block"> | ||||||
| <pre>{ | ||||||
| <pre><code class="language-json5">{ | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For better screen reader support, consider adding an
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| // This is a line comment | ||||||
| "name": "John", /* block comment */ | ||||||
| "age": 30 | ||||||
| }</pre> | ||||||
| }</code></pre> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="feature-card"> | ||||||
| <h3><span class="icon">🔤</span>Unquoted Keys</h3> | ||||||
| <p>Object keys can be unquoted if they're valid identifiers.</p> | ||||||
| <div class="code-block"> | ||||||
| <pre>{ | ||||||
| <pre><code class="language-json5">{ | ||||||
| name: "John", | ||||||
| age: 30, | ||||||
| isActive: true | ||||||
| }</pre> | ||||||
| }</code></pre> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="feature-card"> | ||||||
| <h3><span class="icon">✂️</span>Trailing Commas</h3> | ||||||
| <p>Trailing commas are allowed in objects and arrays.</p> | ||||||
| <div class="code-block"> | ||||||
| <pre>{ | ||||||
| <pre><code class="language-json5">{ | ||||||
| "items": [ | ||||||
| "apple", | ||||||
| "banana", // ← trailing comma OK | ||||||
| ], | ||||||
| }</pre> | ||||||
| }</code></pre> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="feature-card"> | ||||||
| <h3><span class="icon">📝</span>Single Quotes</h3> | ||||||
| <p>Strings can use single quotes in addition to double quotes.</p> | ||||||
| <div class="code-block"> | ||||||
| <pre>{ | ||||||
| <pre><code class="language-json5">{ | ||||||
| 'name': 'John', | ||||||
| "age": 30 | ||||||
| }</pre> | ||||||
| }</code></pre> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="feature-card"> | ||||||
| <h3><span class="icon">📏</span>Multi-line Strings</h3> | ||||||
| <p>Strings can span multiple lines with backslash at line end.</p> | ||||||
| <div class="code-block"> | ||||||
| <pre>{ | ||||||
| <pre><code class="language-json5">{ | ||||||
| "description": "This is a \ | ||||||
| very long string that \ | ||||||
| spans multiple lines" | ||||||
| }</pre> | ||||||
| }</code></pre> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="feature-card"> | ||||||
| <h3><span class="icon">🔢</span>Extended Numbers</h3> | ||||||
| <p>Support for hexadecimal, infinity, NaN, and leading/trailing decimal points.</p> | ||||||
| <div class="code-block"> | ||||||
| <pre>{ | ||||||
| <pre><code class="language-json5">{ | ||||||
| hex: 0xFF, | ||||||
| leadingDecimal: .5, | ||||||
| trailingDecimal: 2., | ||||||
| infinity: Infinity, | ||||||
| notANumber: NaN | ||||||
| }</pre> | ||||||
| }</code></pre> | ||||||
| </div> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
@@ -363,7 +365,7 @@ <h2>Quick Start Guide</h2> | |||||
| <h3>Installation</h3> | ||||||
| <p>Add the dependency to your <code>build.gradle.kts</code>:</p> | ||||||
| <div class="code-block"> | ||||||
| <pre>repositories { | ||||||
| <pre><code class="language-groovy">repositories { | ||||||
| maven { | ||||||
| name = "GitHubPackages" | ||||||
| url = uri("https://maven.pkg.github.com/hossain-khan/json5-kotlin") | ||||||
|
|
@@ -376,12 +378,12 @@ <h3>Installation</h3> | |||||
|
|
||||||
| dependencies { | ||||||
| implementation("hossain.dev:json5kt:1.2.0") // Or, latest release | ||||||
| }</pre> | ||||||
| }</code></pre> | ||||||
| </div> | ||||||
|
|
||||||
| <h3>Basic Usage</h3> | ||||||
| <div class="code-block"> | ||||||
| <pre>import dev.hossain.json5kt.JSON5 | ||||||
| <pre><code class="language-kotlin">import dev.hossain.json5kt.JSON5 | ||||||
|
|
||||||
| // Parse JSON5 string | ||||||
| val json5String = """ | ||||||
|
|
@@ -396,19 +398,19 @@ <h3>Basic Usage</h3> | |||||
| } | ||||||
| """ | ||||||
|
|
||||||
| val user = JSON5.decodeFromString<User>(json5String) | ||||||
| val user = JSON5.decodeFromString<User>(json5String) | ||||||
|
|
||||||
| // Serialize to JSON5 | ||||||
| val json5Output = JSON5.encodeToString(user)</pre> | ||||||
| val json5Output = JSON5.encodeToString(user)</code></pre> | ||||||
| </div> | ||||||
|
|
||||||
| <h3>Integration with kotlinx.serialization</h3> | ||||||
| <div class="code-block"> | ||||||
| <pre>@Serializable | ||||||
| <pre><code class="language-kotlin">@Serializable | ||||||
| data class User( | ||||||
| val name: String, | ||||||
| val age: Int, | ||||||
| val skills: List<String> | ||||||
| val skills: List<String> | ||||||
| ) | ||||||
|
|
||||||
| // Configure JSON5 with custom settings | ||||||
|
|
@@ -417,7 +419,7 @@ <h3>Integration with kotlinx.serialization</h3> | |||||
| ignoreUnknownKeys = true | ||||||
| } | ||||||
|
|
||||||
| val user = json5.decodeFromString<User>(json5String)</pre> | ||||||
| val user = json5.decodeFromString<User>(json5String)</code></pre> | ||||||
| </div> | ||||||
|
|
||||||
| <div class="cta-section"> | ||||||
|
|
@@ -794,6 +796,8 @@ <h3>Methodology</h3> | |||||
| document.addEventListener('DOMContentLoaded', function() { | ||||||
| // Default to overview tab | ||||||
| showTab('overview'); | ||||||
| // Initialize Highlight.js | ||||||
| hljs.highlightAll(); | ||||||
| }); | ||||||
| </script> | ||||||
| </body> | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding Subresource Integrity (SRI)
integrityandcrossorigin="anonymous"attributes to the CDN links to ensure the assets haven’t been tampered with.Copilot uses AI. Check for mistakes.