Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Sep 5, 2025

This pull request introduces support for displaying 3-phase (HMT) inverter data in the web application, enhancing both backend data handling and frontend display logic. The changes add new fields for 3-phase measurements, update the UI to show per-phase information when available, and improve type safety and flexibility in the codebase.

Backend: Support for 3-phase inverter data

  • Added new fields for 3-phase voltage (Voltage Ph1-N, Voltage Ph2-N, Voltage Ph3-N) and current (Current Ph1, Current Ph2, Current Ph3) in both the backend response (addField logic) and the TypeScript types for inverter statistics. [1] [2]

Frontend: UI enhancements for 3-phase inverters

  • Updated the main view (HomeView.vue) to detect 3-phase inverters and display individual phase data, including calculated per-phase power, in addition to the AC summary. Added utility methods isThreePhaseInverter and getPhaseDataWithPower to facilitate this. [1] [2]
  • Improved the InverterChannelInfo component to optionally accept a phaseNumber prop, and updated the header rendering logic to display either the phase number or a generic "AC" label as appropriate. [1] [2] [3]

Type and prop improvements

  • Changed the channelData prop in InverterChannelInfo.vue to accept a Partial<InverterStatistics>, allowing for flexible display of partial phase data.
  • Updated imports and type usage in HomeView.vue to accommodate new and partial inverter statistics types.

@Copilot Copilot AI changed the title [WIP] [Request] Show all 3-phases for HMT inverters in live view Show all 3 phases for HMT inverters in live view Sep 5, 2025
@Copilot Copilot AI requested a review from AndreasBoehm September 5, 2025 07:07
Copilot finished work on behalf of AndreasBoehm September 5, 2025 07:07
Copilot finished work on behalf of AndreasBoehm September 5, 2025 07:12
@spcqike
Copy link

spcqike commented Sep 5, 2025

the preview only shows power for phase1. shouldn't it show a power for all three phases? or, if its distributed evenly, a dedicated "overall" row?

Copy link

github-actions bot commented Sep 10, 2025

Build Artifacts

Firmware built from this pull request's code:

Notice

  • These artifacts are ZIP files containing the factory update binary as well as the OTA update binary.
    Extract the binaries from the ZIP files first. Do not use the ZIP files themselves to perform an update.
  • These links point to artifacts of the latest successful build run.
  • The linked artifacts were built from 37c053b.

@AndreasBoehm

This comment was marked as outdated.

@vaterlangen
Copy link

grafik

Phase 1 shows the overall power and Phase2+3 are missing the power values. Guess we should add either an "Overall/AC" card for AC values related to all phases or add overall AC-power to the "General" card

@spcqike
Copy link

spcqike commented Sep 13, 2025

As third option you could also calculate power per phase, as you already have voltage and current.

@vaterlangen
Copy link

As third option you could also calculate power per phase, as you already have voltage and current.

Yes, definitely. Power per phase AND Overall power (as this is the relevant measurement value for DPL)

@AndreasBoehm

This comment was marked as outdated.

@Copilot Copilot AI changed the title Show all 3 phases for HMT inverters in live view Show AC section for all inverters plus individual phase sections for 3-phase HMT inverters Sep 14, 2025
Copilot finished work on behalf of AndreasBoehm September 14, 2025 14:59
@AndreasBoehm

This comment was marked as outdated.

This comment was marked as outdated.

Copilot finished work on behalf of AndreasBoehm September 14, 2025 15:26
@AndreasBoehm AndreasBoehm deleted the copilot/fix-1564 branch September 17, 2025 11:37
@AndreasBoehm AndreasBoehm restored the copilot/fix-1564 branch September 17, 2025 13:32
@AndreasBoehm AndreasBoehm reopened this Sep 17, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the inverter display interface to properly support both single-phase and 3-phase (HMT) inverters. The key improvement is showing AC summary data for all inverters while additionally displaying individual phase data for 3-phase systems.

Key changes:

  • Added automatic detection of 3-phase vs single-phase inverters
  • Enhanced AC display logic to show combined AC data plus individual phase sections for 3-phase inverters
  • Extended backend API to include HMT-specific 3-phase voltage and current fields

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
webapp/src/views/HomeView.vue Added 3-phase detection logic, phase data extraction methods, and enhanced AC rendering template
webapp/src/types/LiveDataStatus.ts Extended InverterStatistics interface with 3-phase voltage and current field definitions
webapp/src/locales/en.json Added "AC" translation for cleaner single-phase inverter labels
webapp/src/components/InverterChannelInfo.vue Enhanced component to handle phase-specific labeling and optional phase numbers
src/WebApi_ws_live.cpp Added HMT-specific 3-phase field support to backend JSON output

@AndreasBoehm AndreasBoehm changed the title Show AC section for all inverters plus individual phase sections for 3-phase HMT inverters webapp: show data for all 3-phases for HMT inverters in live view Oct 9, 2025
@hoylabs hoylabs deleted a comment from Copilot AI Oct 9, 2025
@hoylabs hoylabs deleted a comment from Copilot AI Oct 9, 2025
@hoylabs hoylabs deleted a comment from Copilot AI Oct 9, 2025
@AndreasBoehm AndreasBoehm marked this pull request as ready for review October 9, 2025 18:37
@AndreasBoehm
Copy link
Member

@vaterlangen @Saarblick @kthemall

Please give the test version a try and let me know if it looks as expected. I don't have a HMT inverter myself and can't try it.

#2195 (comment)

@vaterlangen
Copy link

vaterlangen commented Oct 11, 2025

@AndreasBoehm Phase Values seem to be correct.
In AC card, current and voltage are misleading. Phase-to-Earth voltages and phase currents are duplicated. IMHO, Instead of Phase-to-earth voltages phase-to-phase voltages would be more meaningful.

image
More Pictures

Screenshot_20251011-110822~2

Screenshot_20251011-110830~3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants