-
-
Notifications
You must be signed in to change notification settings - Fork 91
webapp: show data for all 3-phases for HMT inverters in live view #2195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
the preview only shows power for phase1. shouldn't it show a power for all three phases? or, if its distributed evenly, a dedicated "overall" row? |
c2433e2
to
9044bd5
Compare
Build ArtifactsFirmware built from this pull request's code:
Notice
|
This comment was marked as outdated.
This comment was marked as outdated.
As third option you could also calculate power per phase, as you already have voltage and current. |
Yes, definitely. Power per phase AND Overall power (as this is the relevant measurement value for DPL) |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cb6afdf
to
6963e88
Compare
6963e88
to
b9639c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the inverter display interface to properly support both single-phase and 3-phase (HMT) inverters. The key improvement is showing AC summary data for all inverters while additionally displaying individual phase data for 3-phase systems.
Key changes:
- Added automatic detection of 3-phase vs single-phase inverters
- Enhanced AC display logic to show combined AC data plus individual phase sections for 3-phase inverters
- Extended backend API to include HMT-specific 3-phase voltage and current fields
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
webapp/src/views/HomeView.vue | Added 3-phase detection logic, phase data extraction methods, and enhanced AC rendering template |
webapp/src/types/LiveDataStatus.ts | Extended InverterStatistics interface with 3-phase voltage and current field definitions |
webapp/src/locales/en.json | Added "AC" translation for cleaner single-phase inverter labels |
webapp/src/components/InverterChannelInfo.vue | Enhanced component to handle phase-specific labeling and optional phase numbers |
src/WebApi_ws_live.cpp | Added HMT-specific 3-phase field support to backend JSON output |
@vaterlangen @Saarblick @kthemall Please give the test version a try and let me know if it looks as expected. I don't have a HMT inverter myself and can't try it. |
@AndreasBoehm Phase Values seem to be correct. ![]() |
This pull request introduces support for displaying 3-phase (HMT) inverter data in the web application, enhancing both backend data handling and frontend display logic. The changes add new fields for 3-phase measurements, update the UI to show per-phase information when available, and improve type safety and flexibility in the codebase.
Backend: Support for 3-phase inverter data
Voltage Ph1-N
,Voltage Ph2-N
,Voltage Ph3-N
) and current (Current Ph1
,Current Ph2
,Current Ph3
) in both the backend response (addField
logic) and the TypeScript types for inverter statistics. [1] [2]Frontend: UI enhancements for 3-phase inverters
HomeView.vue
) to detect 3-phase inverters and display individual phase data, including calculated per-phase power, in addition to the AC summary. Added utility methodsisThreePhaseInverter
andgetPhaseDataWithPower
to facilitate this. [1] [2]InverterChannelInfo
component to optionally accept aphaseNumber
prop, and updated the header rendering logic to display either the phase number or a generic "AC" label as appropriate. [1] [2] [3]Type and prop improvements
channelData
prop inInverterChannelInfo.vue
to accept aPartial<InverterStatistics>
, allowing for flexible display of partial phase data.HomeView.vue
to accommodate new and partial inverter statistics types.