Installation fix #293
Open
Installation fix #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
#include "pdc_client_connect.h"frompdc.h.Some tests then must include
pdc_client_connect.hexplicitly because they are calling private functions such asPDC_Client_insert_obj_ref_into_dart. I believe these are private because thepdc_naming_policy.txtstates:Private function: starting with capital PDC and underscore "_" after, example
If these are not private then they should probably be renamed and put into their own header file.
This also required some incorrect uses of
PGOTO_DONEin the test code to be changed toTGOTO_DONE.#284